Clean-up inline members of nested classes (net/)

net/base/network_change_notifier_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NETWORK_CHANGE_NOTIFIER_MAC_H_
 #define NET_BASE_NETWORK_CHANGE_NOTIFIER_MAC_H_
 
 #include <SystemConfiguration/SystemConfiguration.h>
 
 #include "base/basictypes.h"
@@ skipping 15 matching lines @@
   // NetworkChangeNotifier implementation:
   virtual ConnectionType GetCurrentConnectionType() const OVERRIDE;
 
   class DnsWatcherThread;
 
   // Forwarder just exists to keep the NetworkConfigWatcherMac API out of
   // NetworkChangeNotifierMac's public API.
   class Forwarder : public NetworkConfigWatcherMac::Delegate {
    public:
     explicit Forwarder(NetworkChangeNotifierMac* net_config_watcher)
         : net_config_watcher_(net_config_watcher) {}

[mmenke, 2012/08/09 15:13:35]

Shouldn't this be de-inlined as well?

[hans, 2012/08/09 15:35:42]

The plugin doesn't consider it to be complex enough to require that. It's using
a points-based system:
http://dev.chromium.org/developers/coding-style/chromium-style-checker-errors...

I can out-of-line it for consistency if you'd like, but the plugin isn't
complaining about it.

[mmenke, 2012/08/09 15:41:51]

I'm fine with it as-is, just wasn't sure if you were missing stuff or not. 
Thanks for the link.

 
     // NetworkConfigWatcherMac::Delegate implementation:
-    virtual void Init() OVERRIDE {
-      net_config_watcher_->SetInitialConnectionType();
-    }
-    virtual void StartReachabilityNotifications() OVERRIDE {
-      net_config_watcher_->StartReachabilityNotifications();
-    }
+    virtual void Init() OVERRIDE;
+    virtual void StartReachabilityNotifications() OVERRIDE;
     virtual void SetDynamicStoreNotificationKeys(
-        SCDynamicStoreRef store) OVERRIDE {
-      net_config_watcher_->SetDynamicStoreNotificationKeys(store);
-    }
-    virtual void OnNetworkConfigChange(CFArrayRef changed_keys) OVERRIDE {
-      net_config_watcher_->OnNetworkConfigChange(changed_keys);
-    }
+        SCDynamicStoreRef store) OVERRIDE;
+    virtual void OnNetworkConfigChange(CFArrayRef changed_keys) OVERRIDE;
 
    private:
     NetworkChangeNotifierMac* const net_config_watcher_;
     DISALLOW_COPY_AND_ASSIGN(Forwarder);
   };
 
   // Methods directly called by the NetworkConfigWatcherMac::Delegate:
   void StartReachabilityNotifications();
   void SetDynamicStoreNotificationKeys(SCDynamicStoreRef store);
   void OnNetworkConfigChange(CFArrayRef changed_keys);
@@ skipping 18 matching lines @@
 
   // Thread on which we can run DnsConfigWatcher, which requires TYPE_IO.
   scoped_ptr<DnsWatcherThread> dns_watcher_thread_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkChangeNotifierMac);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_NETWORK_CHANGE_NOTIFIER_MAC_H_