Issue 10854061: Revert 150726 - Preload default wallpaper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10854061: Revert 150726 - Preload default wallpaper. (Closed)

Created:
8 years, 4 months ago by jeremya

Modified:
8 years, 4 months ago

Reviewers:
bshe

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 150726 - Preload default wallpaper. BUG=139929 Review URL: https://chromiumcodereview.appspot.com/10827154 TBR=bshe@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150740

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -126 lines)			Patch
M	ash/desktop_background/desktop_background_controller.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	ash/desktop_background/desktop_background_controller.cc	View	3 chunks	+9 lines, -26 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/wallpaper_manager.h	View	3 chunks	+3 lines, -17 lines	0 comments	Download
M	chrome/browser/chromeos/login/wallpaper_manager.cc	View	7 chunks	+19 lines, -75 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jeremya

8 years, 4 months ago (2012-08-09 05:19:23 UTC) #2

Hi bshe-

I think this patch broke ScreenLockerTest.{TestBasic,TestFullscreenExit}. Please
take a look :)

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Expand Messages | Collapse Messages