Issue 10854053: MIPS: Refactor Math.min/max to be a single HInstruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10854053: MIPS: Refactor Math.min/max to be a single HInstruction. (Closed)

Created:
8 years, 4 months ago by palfia

Modified:
8 years, 4 months ago

Reviewers:
kisg, Paul Lind, Yang, danno, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Refactor Math.min/max to be a single HInstruction. Port r12265 (7501dd73) BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12282

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -1 line)			Patch
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+65 lines, -0 lines	2 comments	Download
M	src/mips/lithium-mips.h	View	4 chunks	+14 lines, -1 line	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years, 4 months ago (2012-08-09 08:30:08 UTC) #2

LGTM except for two ARM-specific comments. I removed those comments and am
landing this patch.

https://chromiumcodereview.appspot.com/10854053/diff/1/src/mips/lithium-codeg...
File src/mips/lithium-codegen-mips.cc (right):

https://chromiumcodereview.appspot.com/10854053/diff/1/src/mips/lithium-codeg...
src/mips/lithium-codegen-mips.cc:1399: // We could use a single 'vorr'
instruction here if we had NEON support.
Comment only applies to ARM.

https://chromiumcodereview.appspot.com/10854053/diff/1/src/mips/lithium-codeg...
src/mips/lithium-codegen-mips.cc:1404: // Since we operate on +0 and/or -0, vadd
and vand have the same effect;
Comment only applies to ARM.

Expand Messages | Collapse Messages