Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2812)

Unified Diff: chrome/browser/sync/glue/sync_backend_host.cc

Issue 10854050: sync: Remove WITH_NIGORI and WITHOUT_NIGORI flags (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nit Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/sync_backend_host.cc
diff --git a/chrome/browser/sync/glue/sync_backend_host.cc b/chrome/browser/sync/glue/sync_backend_host.cc
index ccf8bf65fa0d5eb0b56e3515e465edea028827a2..7c0ac45735dcba6fb03b4006c8665e2f34745c31 100644
--- a/chrome/browser/sync/glue/sync_backend_host.cc
+++ b/chrome/browser/sync/glue/sync_backend_host.cc
@@ -631,7 +631,6 @@ void SyncBackendHost::ConfigureDataTypes(
syncer::ConfigureReason reason,
syncer::ModelTypeSet types_to_add,
syncer::ModelTypeSet types_to_remove,
- NigoriState nigori_state,
const base::Callback<void(syncer::ModelTypeSet)>& ready_task,
const base::Callback<void()>& retry_callback) {
// Only one configure is allowed at a time. This is guaranteed by our
@@ -642,20 +641,9 @@ void SyncBackendHost::ConfigureDataTypes(
DCHECK_GT(initialization_state_, NOT_INITIALIZED);
- syncer::ModelTypeSet types_to_add_with_nigori = types_to_add;
- syncer::ModelTypeSet types_to_remove_with_nigori = types_to_remove;
- if (nigori_state == WITH_NIGORI) {
- types_to_add_with_nigori.Put(syncer::NIGORI);
- types_to_remove_with_nigori.Remove(syncer::NIGORI);
- } else {
- types_to_add_with_nigori.Remove(syncer::NIGORI);
- types_to_remove_with_nigori.Put(syncer::NIGORI);
- }
-
// The SyncBackendRegistrar's routing info will be updated by adding the
- // types_to_add_with_nigori to the list then removing
- // types_to_remove_with_nigori. Any types which are not in either of those
- // sets will remain untouched.
+ // types_to_add to the list then removing types_to_remove. Any types which
+ // are not in either of those sets will remain untouched.
//
// Types which were not in the list previously are not fully downloaded, so we
// must ask the syncer to download them. Any newly supported datatypes will
@@ -669,7 +657,7 @@ void SyncBackendHost::ConfigureDataTypes(
// until they succeed or the browser is closed.
syncer::ModelTypeSet types_to_download = registrar_->ConfigureDataTypes(
- types_to_add_with_nigori, types_to_remove_with_nigori);
+ types_to_add, types_to_remove);
if (!types_to_download.Empty())
types_to_download.Put(syncer::NIGORI);
@@ -1328,9 +1316,8 @@ void SyncBackendHost::HandleInitializationCompletedOnFrontendLoop(
initialization_state_ = DOWNLOADING_NIGORI;
ConfigureDataTypes(
syncer::CONFIGURE_REASON_NEW_CLIENT,
+ syncer::ModelTypeSet(syncer::NIGORI),
syncer::ModelTypeSet(),
- syncer::ModelTypeSet(),
- WITH_NIGORI,
// Calls back into this function.
base::Bind(
&SyncBackendHost::
« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host.h ('k') | chrome/browser/sync/glue/sync_backend_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698