Add histograms for total allocated/live heap size, as well as allocated size and percentage of tota…

src/v8-counters.cc

Index: src/v8-counters.cc
diff --git a/src/v8-counters.cc b/src/v8-counters.cc
index 36b45e2f8e8449d2a7d0636b88121ea924a4e697..3f83dffcae6fb7192056803171390d05cde9e36c 100644
--- a/src/v8-counters.cc
+++ b/src/v8-counters.cc
@@ -45,6 +45,12 @@ Counters::Counters() {
     HISTOGRAM_PERCENTAGE_LIST(HP)
 #undef HP
 
+#define HM(name, caption) \
+    Histogram name = { #caption, 1000, 500000, 50, NULL, false }; \

[Michael Starzinger, 2012/08/08 18:44:36]

This seems to set the maximum value for memory histograms to ~500MB, the total
heap size can easily exceed that. On ia32 we limit the old generation to 700MB,
on x64 to 1400MB. I'm not that familiar with how the histograms work and if that
poses a problem, just wanted to point it out.

[jochen (gone - plz use gerrit), 2012/08/09 13:31:29]

It's the usual histogram layout for KB values (see base/metrics/histogram.h).
The upper bound of the last bucket is INT_MAX

+    name##_ = name;
+    HISTOGRAM_MEMORY_LIST(HM)
+#undef HM
+
 #define SC(name, caption) \
     StatsCounter name = { "c:" #caption, NULL, false };\
     name##_ = name;
@@ -101,6 +107,10 @@ void Counters::ResetHistograms() {
 #define HP(name, caption) name##_.Reset();
     HISTOGRAM_PERCENTAGE_LIST(HP)
 #undef HP
+
+#define HM(name, caption) name##_.Reset();
+    HISTOGRAM_MEMORY_LIST(HM)
+#undef HM
 }
 
 } }  // namespace v8::internal