Redesign the color chooser view for HiDPI devices.

Redesign the color chooser view for HiDPI devices.

- DrawPoint makes gap with the next pixel, so FillRect instead
- FillRect to draw the border rather than DrawRect.  DrawRect makes thin gap
  with the contents.
- Fill the center point of the crosshair.  That is not necessary since
  we have selected color patch, and this lack of center point looks ugly
  on HiDPI devices.

BUG=139991
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151222

[sadrul, 2012-08-09 16:36:04]

http://codereview.chromium.org/10854039/diff/1/ui/views/color_chooser/color_c...
File ui/views/color_chooser/color_chooser_view.cc (right):

http://codereview.chromium.org/10854039/diff/1/ui/views/color_chooser/color_c...
ui/views/color_chooser/color_chooser_view.cc:300: canvas->DrawLine(
You probably want to replace all DrawLine()s with FillRect()s (it looks like
nothing else in ui/views/ uses DrawLine())

[Jun Mukai, 2012-08-10 04:50:14]

http://codereview.chromium.org/10854039/diff/1/ui/views/color_chooser/color_c...
File ui/views/color_chooser/color_chooser_view.cc (right):

http://codereview.chromium.org/10854039/diff/1/ui/views/color_chooser/color_c...
ui/views/color_chooser/color_chooser_view.cc:300: canvas->DrawLine(
On 2012/08/09 16:36:04, sadrul wrote:
> You probably want to replace all DrawLine()s with FillRect()s (it looks like
> nothing else in ui/views/ uses DrawLine())

Done.

[sadrul, 2012-08-10 14:19:06]

lgtm

[commit-bot: I haz the power, 2012-08-13 01:51:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/10854039/5001

[commit-bot: I haz the power, 2012-08-13 04:15:04]

Change committed as 151222