Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 10854028: Fix Windows bat file for SDK try (Closed)

Created:
8 years, 4 months ago by noelallen1
Modified:
8 years, 4 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews
Visibility:
Public.

Description

Fix Windows bat file for SDK try The script currently does not run tries, since the try mechanism rejects the entire request if any requrest bot is bogus. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150839

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M native_client_sdk/src/sdktry.bat View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
noelallen1
8 years, 4 months ago (2012-08-07 18:27:21 UTC) #1
bradn
lgtm
8 years, 4 months ago (2012-08-07 18:29:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10854028/1
8 years, 4 months ago (2012-08-08 18:36:52 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 18:36:54 UTC) #4
Failed to apply patch for native_client_sdk/src/sdktry.bat:
While running patch -p0 --forward --force;
patching file native_client_sdk/src/sdktry.bat
Hunk #1 FAILED at 7.
1 out of 1 hunk FAILED -- saving rejects to file
native_client_sdk/src/sdktry.bat.rej

Powered by Google App Engine
This is Rietveld 408576698