Remove log message for 10.8 CFAllocator patching.

Remove log message for 10.8 CFAllocator patching.

BUG=117476
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150385

[Avi (use Gerrit), 2012-08-07 16:39:05]

This log gains us nothing and in the future I plan to not add it for new system
releases.

If indeed the allocator format changes on us for a pre-release system, it will
be obvious in the crashes and we can react as soon as we get the bugs ("Chrome
crashes on launch when I run 10.9 alpha! OMG"). In the meanwhile, all it does is
attract the attention of people who scour logs looking for something to blame
for when something else goes wrong in Chrome.

I will keep bug 117476 open until I can verify the change in CFAllocator for
Mountain Lion.

[Mark Mentovai, 2012-08-07 16:43:03]

This is fine, but I’d also be fine if you just quieted things down by making
only the browser process log these messages.

What about this question:

https://chromiumcodereview.appspot.com/10854027/diff/1/base/process_util_mac.mm
File base/process_util_mac.mm (right):

https://chromiumcodereview.appspot.com/10854027/diff/1/base/process_util_mac....
base/process_util_mac.mm:774:
IsOSDangerouslyLaterThanMountainLionForUseByCFAllocatorReplacement();
We’re gonna need to remember to do something with this each time there’s a new
major OS version. How do you plan to track that?

[Avi (use Gerrit), 2012-08-07 16:54:54]

https://chromiumcodereview.appspot.com/10854027/diff/1/base/process_util_mac.mm
File base/process_util_mac.mm (right):

https://chromiumcodereview.appspot.com/10854027/diff/1/base/process_util_mac....
base/process_util_mac.mm:774:
IsOSDangerouslyLaterThanMountainLionForUseByCFAllocatorReplacement();
I plan on doing all of the same work; digging up the new structure, updating
base::mac, etc, etc. I just don't want to log "hey we're patching it anyway"
since that accomplishes nothing.

Note the length of this comment as opposed to the one from 10.7. This is thrice
the length trying to explain to people when to file bugs and where. It's clear
that doesn't work.

[Mark Mentovai, 2012-08-07 17:01:08]

https://chromiumcodereview.appspot.com/10854027/diff/1/base/process_util_mac.mm
File base/process_util_mac.mm (right):

https://chromiumcodereview.appspot.com/10854027/diff/1/base/process_util_mac....
base/process_util_mac.mm:1026: NSLog(@"Internals of CFAllocator not known;
out-of-memory failures via "
OK, so when 10.next starts running, people will see THIS message spamming the
console. Are we still OK with that too, or do we want to try to make this
browser-only?

[Avi (use Gerrit), 2012-08-07 17:10:08]

https://chromiumcodereview.appspot.com/10854027/diff/1/base/process_util_mac.mm
File base/process_util_mac.mm (right):

https://chromiumcodereview.appspot.com/10854027/diff/1/base/process_util_mac....
base/process_util_mac.mm:1026: NSLog(@"Internals of CFAllocator not known;
out-of-memory failures via "
a. Yes, I'm OK with this message. The amount of time between a new system
release and our update to the CFAllocator code is going to be significantly less
than the time during which we are running unverified CFAllocator patch code.
Plus, the people who are running Chrome during that time are more experienced
devs, as opposed to the wide range of people who run the beta and the release.

b. If you look at content_main_runner's Initialize(), the call to
EnableTerminationOnOutOfMemory() precedes command-line parsing. You need to
parse the command line to determine if you are the browser process, but enabling
the OOM killer is something that I'd really like to keep early in the app
startup code. Could someone do an OOM attack via the command-line?

[Mark Mentovai, 2012-08-07 17:43:45]

You can figure out if you’re a browser process in Mac-only code by calling
base::mac::IsBackgroundOnlyProcess().

LGTM anyway.

[commit-bot: I haz the power, 2012-08-07 17:48:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10854027/1

[commit-bot: I haz the power, 2012-08-07 19:06:15]

Change committed as 150385