Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: chrome/test/webdriver/commands/target_locator_commands.cc

Issue 10854026: Added webdriver support for App v2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added a comment. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/automation_id.h ('k') | chrome/test/webdriver/test/app_shell_extension/bg.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/commands/target_locator_commands.cc
diff --git a/chrome/test/webdriver/commands/target_locator_commands.cc b/chrome/test/webdriver/commands/target_locator_commands.cc
index 5b28a66a3c6b3b352ed652106c6ca47ca39d3eca..9fb37b42b20ae3d334bffed17c906c54470fa6ff 100644
--- a/chrome/test/webdriver/commands/target_locator_commands.cc
+++ b/chrome/test/webdriver/commands/target_locator_commands.cc
@@ -52,7 +52,8 @@ void WindowHandlesCommand::ExecuteGet(Response* const response) {
}
base::ListValue* id_list = new base::ListValue();
for (size_t i = 0; i < views.size(); ++i) {
- if (!views[i].view_id.IsTab())
+ if (!views[i].view_id.IsTab() &&
+ views[i].view_id.GetId().type() != AutomationId::kTypeAppShell)
continue;
id_list->Append(Value::CreateStringValue(
WebViewIdToString(views[i].view_id)));
« no previous file with comments | « chrome/common/automation_id.h ('k') | chrome/test/webdriver/test/app_shell_extension/bg.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698