Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: lib/unittest/html_config.dart

Issue 10854013: Clean up the test srapper code so that it does not use reportTestError, and made that private. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * A simple unit test library for running tests in a browser. 6 * A simple unit test library for running tests in a browser.
7 */ 7 */
8 #library('unittest'); 8 #library('unittest');
9 9
10 #import('dart:html'); 10 #import('dart:html');
11 #import('unittest.dart'); 11 #import('unittest.dart');
12 12
13 #source('html_print.dart'); 13 #source('html_print.dart');
14 14
15 class HtmlConfiguration extends Configuration { 15 class HtmlConfiguration extends Configuration {
16 /** Whether this is run within dartium layout tests. */ 16 /** Whether this is run within dartium layout tests. */
17 final bool _isLayoutTest; 17 final bool _isLayoutTest;
18 HtmlConfiguration(this._isLayoutTest); 18 HtmlConfiguration(this._isLayoutTest);
19 19
20 // TODO(rnystrom): Get rid of this if we get canonical closures for methods. 20 // TODO(rnystrom): Get rid of this if we get canonical closures for methods.
21 EventListener _onErrorClosure; 21 EventListener _onErrorClosure;
22 22
23 void onInit() { 23 void onInit() {
24 _onErrorClosure = (e) { 24 _onErrorClosure =
25 // TODO(vsm): figure out how to expose the stack trace here 25 (e) => handleExternalError(e, '(DOM callback has errors)');
26 // Currently e.message works in dartium, but not in dartc.
27 reportTestError('(DOM callback has errors) Caught ${e}', '');
28 };
29 } 26 }
30 27
31 void onStart() { 28 void onStart() {
32 window.postMessage('unittest-suite-wait-for-done', '*'); 29 window.postMessage('unittest-suite-wait-for-done', '*');
33 // Listen for uncaught errors. 30 // Listen for uncaught errors.
34 window.on.error.add(_onErrorClosure); 31 window.on.error.add(_onErrorClosure);
35 } 32 }
36 33
37 void onTestResult(TestCase testCase) {} 34 void onTestResult(TestCase testCase) {}
38 35
39 void onDone(int passed, int failed, int errors, List<TestCase> results, 36 void onDone(int passed, int failed, int errors, List<TestCase> results,
40 String uncaughtError) { 37 String uncaughtError) {
41 window.on.error.remove(_onErrorClosure); 38 window.on.error.remove(_onErrorClosure);
42 _showResultsInPage(passed, failed, errors, results, _isLayoutTest, 39 _showResultsInPage(passed, failed, errors, results, _isLayoutTest,
43 uncaughtError); 40 uncaughtError);
44 window.postMessage('unittest-suite-done', '*'); 41 window.postMessage('unittest-suite-done', '*');
45 } 42 }
46 } 43 }
47 44
48 void useHtmlConfiguration([bool isLayoutTest = false]) { 45 void useHtmlConfiguration([bool isLayoutTest = false]) {
49 configure(new HtmlConfiguration(isLayoutTest)); 46 configure(new HtmlConfiguration(isLayoutTest));
50 } 47 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698