Issue 10853018: Fall back to the default favicon on invalid favicon files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10853018: Fall back to the default favicon on invalid favicon files. (Closed)

Created:
8 years, 4 months ago by Nico

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, pkotwicz

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fall back to the default favicon on invalid favicon files. I regressed this in r149891. BUG=140689 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150092

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -4 lines)			Patch
M	chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm	View	1 chunk	+1 line, -1 line	1 comment	Download
M	ui/gfx/image/image.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	ui/gfx/image/image.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

https://chromiumcodereview.appspot.com/10853018/diff/1/chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm File chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm (right): https://chromiumcodereview.appspot.com/10853018/diff/1/chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm#newcode22 chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm:22: NSImage* image = contents->favicon_tab_helper()->GetFavicon().AsNSImage(); (Also fixes a frequent crasher ...

8 years, 4 months ago (2012-08-05 04:44:48 UTC) #2

commit-bot: I haz the power

8 years, 4 months ago (2012-08-06 15:10:56 UTC) #4

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10853018/1

Expand Messages | Collapse Messages