Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Side by Side Diff: tools/clang/plugins/ChromeClassTester.cpp

Issue 10853012: Add cc/ to banned_directories in chromium clang style checker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // A general interface for filtering and only acting on classes in Chromium C++ 5 // A general interface for filtering and only acting on classes in Chromium C++
6 // code. 6 // code.
7 7
8 #include "ChromeClassTester.h" 8 #include "ChromeClassTester.h"
9 9
10 #include <sys/param.h> 10 #include <sys/param.h>
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 banned_directories_.push_back("pdf/"); 155 banned_directories_.push_back("pdf/");
156 banned_directories_.push_back("ppapi/"); 156 banned_directories_.push_back("ppapi/");
157 banned_directories_.push_back("usr/"); 157 banned_directories_.push_back("usr/");
158 banned_directories_.push_back("testing/"); 158 banned_directories_.push_back("testing/");
159 banned_directories_.push_back("googleurl/"); 159 banned_directories_.push_back("googleurl/");
160 banned_directories_.push_back("v8/"); 160 banned_directories_.push_back("v8/");
161 banned_directories_.push_back("dart/"); 161 banned_directories_.push_back("dart/");
162 banned_directories_.push_back("sdch/"); 162 banned_directories_.push_back("sdch/");
163 banned_directories_.push_back("icu4c/"); 163 banned_directories_.push_back("icu4c/");
164 banned_directories_.push_back("frameworks/"); 164 banned_directories_.push_back("frameworks/");
165 banned_directories_.push_back("cc/");
Nico 2012/08/04 00:51:09 Do you want to make this conditional on a flag? If
jamesr 2012/08/04 00:52:10 Sure, how do I get access to flags from a clang pl
165 166
166 // Don't check autogenerated headers. 167 // Don't check autogenerated headers.
167 // Make puts them below $(builddir_name)/.../gen and geni. 168 // Make puts them below $(builddir_name)/.../gen and geni.
168 // Ninja puts them below OUTPUT_DIR/.../gen 169 // Ninja puts them below OUTPUT_DIR/.../gen
169 // Xcode has a fixed output directory for everything. 170 // Xcode has a fixed output directory for everything.
170 banned_directories_.push_back("gen/"); 171 banned_directories_.push_back("gen/");
171 banned_directories_.push_back("geni/"); 172 banned_directories_.push_back("geni/");
172 banned_directories_.push_back("xcodebuild/"); 173 banned_directories_.push_back("xcodebuild/");
173 174
174 // You are standing in a mazy of twisty dependencies, all resolved by 175 // You are standing in a mazy of twisty dependencies, all resolved by
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 PresumedLoc ploc = source_manager.getPresumedLoc(spelling_location); 294 PresumedLoc ploc = source_manager.getPresumedLoc(spelling_location);
294 if (ploc.isInvalid()) { 295 if (ploc.isInvalid()) {
295 // If we're in an invalid location, we're looking at things that aren't 296 // If we're in an invalid location, we're looking at things that aren't
296 // actually stated in the source. 297 // actually stated in the source.
297 return false; 298 return false;
298 } 299 }
299 300
300 *filename = ploc.getFilename(); 301 *filename = ploc.getFilename();
301 return true; 302 return true;
302 } 303 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698