Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 10853010: Add webkit/ api to request all frames in an image. (Closed)

Created:
8 years, 4 months ago by Nico
Modified:
8 years, 4 months ago
Reviewers:
tony, jamesr
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Add webkit/ api to request all frames in an image. Depends on https://bugs.webkit.org/show_bug.cgi?id=92933 Not used anywhere yet, so no observable effect. BUG=138550 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150071

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -31 lines) Patch
M webkit/glue/image_decoder.h View 2 chunks +7 lines, -0 lines 0 comments Download
M webkit/glue/image_decoder.cc View 1 chunk +11 lines, -0 lines 0 comments Download
A + webkit/glue/multi_resolution_image_resource_fetcher.h View 3 chunks +13 lines, -17 lines 0 comments Download
A + webkit/glue/multi_resolution_image_resource_fetcher.cc View 1 2 chunks +10 lines, -14 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
https://chromiumcodereview.appspot.com/10853010/diff/1/webkit/glue/multi_resolution_image_resource_fetcher.h File webkit/glue/multi_resolution_image_resource_fetcher.h (right): https://chromiumcodereview.appspot.com/10853010/diff/1/webkit/glue/multi_resolution_image_resource_fetcher.h#newcode21 webkit/glue/multi_resolution_image_resource_fetcher.h:21: class MultiResolutionImageResourceFetcher{ This is fairly similar to ImageResourceFetcher, but ...
8 years, 4 months ago (2012-08-03 22:37:15 UTC) #1
jamesr
I think you can get rid of both reinterpret_cast<>s around data here. Otherwise LGTM
8 years, 4 months ago (2012-08-03 22:47:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10853010/3002
8 years, 4 months ago (2012-08-06 07:25:23 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-06 08:52:01 UTC) #4
Change committed as 150071

Powered by Google App Engine
This is Rietveld 408576698