Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 10852016: Move serial out of experimental. (Closed)

Created:
8 years, 4 months ago by miket_OOO
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Move serial out of experimental. This CL is unremarkable except that I figured out that we're improperly including some permissions for experimental APIs (which are already covered by the blanket experimental permission). This made it tougher because I used http://codereview.chromium.org/10440097/, which benefited unwittingly from a pre-declared socket permission, as an example. I then ran into missing namespace problems because I hadn't done everything necessary (such as including serial in api_permission.cc). I did my job as a good citizen and removed the superfluous USB permission. Also ran build.py to update docs. BUG=138370 TEST=no new ones; updated old ones to build. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150186

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fix merge conflicts and make asargent's changes. #

Patch Set 3 : Resolve merge conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -3217 lines) Patch
M chrome/browser/extensions/api/serial/serial_api.h View 11 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_api.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/api/experimental_serial.idl View 1 chunk +0 lines, -135 lines 0 comments Download
A + chrome/common/extensions/api/serial.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/apps/api_index.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/apps/experimental.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/apps/experimental.serial.html View 1 2 chunks +3 lines, -1346 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/notifications.zip View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.serial.html View 1 2 chunks +3 lines, -1664 lines 0 comments Download
M chrome/common/extensions/docs/extensions/samples.html View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/api_permission.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/dns/api/manifest.json View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/serial/api/background.js View 3 chunks +11 lines, -13 lines 0 comments Download
M chrome/test/data/extensions/api_test/serial/api/manifest.json View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/serial/real_hardware/background.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/serial/real_hardware/manifest.json View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
miket_OOO
8 years, 4 months ago (2012-08-03 23:20:30 UTC) #1
asargent_no_longer_on_chrome
LGTM https://chromiumcodereview.appspot.com/10852016/diff/2001/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://chromiumcodereview.appspot.com/10852016/diff/2001/chrome/common/extensions/api/_permission_features.json#newcode286 chrome/common/extensions/api/_permission_features.json:286: "usb": { should we remove this entry for ...
8 years, 4 months ago (2012-08-03 23:41:07 UTC) #2
miket_OOO
> chrome/common/extensions/api/_permission_features.json:286: "usb": { > should we remove this entry for usb? Yes, did it. ...
8 years, 4 months ago (2012-08-03 23:50:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/10852016/1024
8 years, 4 months ago (2012-08-06 17:59:51 UTC) #4
commit-bot: I haz the power
Try job failure for 10852016-1024 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 18:16:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/10852016/1024
8 years, 4 months ago (2012-08-06 18:26:58 UTC) #6
commit-bot: I haz the power
Try job failure for 10852016-1024 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 4 months ago (2012-08-06 20:14:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/10852016/1024
8 years, 4 months ago (2012-08-06 20:29:52 UTC) #8
commit-bot: I haz the power
Try job failure for 10852016-1024 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=50102 Step "update" is always ...
8 years, 4 months ago (2012-08-06 21:58:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/10852016/1024
8 years, 4 months ago (2012-08-06 22:21:05 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-06 22:54:18 UTC) #11
Try job failure for 10852016-1024 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Powered by Google App Engine
This is Rietveld 408576698