Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 10852014: Drive: Show localtime instead of UTC at "last modified" field of GCache in drive-internals. (Closed)

Created:
8 years, 4 months ago by yoshiki
Modified:
8 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Drive: Show local time instead of UTC at "last modified" field of GCache in drive-internals. This CL show "last modified" date of GCache in local time instead of in UTC. - Before: 2012-08-03T07:28:26.000Z - After: 2012-08-03T00:28:26.000 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150127

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix typo #

Patch Set 3 : Try to pass the local time from C++ side. #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/chromeos/gdata/gdata_util.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_util.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
yoshiki
satorux: It was useful for me on debbuing and may be useful for us.
8 years, 4 months ago (2012-08-03 23:04:59 UTC) #1
satorux1
https://chromiumcodereview.appspot.com/10852014/diff/1/chrome/browser/resources/chromeos/drive_internals.js File chrome/browser/resources/chromeos/drive_internals.js (right): https://chromiumcodereview.appspot.com/10852014/diff/1/chrome/browser/resources/chromeos/drive_internals.js#newcode36 chrome/browser/resources/chromeos/drive_internals.js:36: '[' + last_modified + ']'; Can we instead pass ...
8 years, 4 months ago (2012-08-03 23:06:28 UTC) #2
yoshiki
I tried it at Patch Set 3. But it is currently lacking the timezone suffix ...
8 years, 4 months ago (2012-08-03 23:29:24 UTC) #3
satorux1
LGTM. Let's go with the C++ solution. Tweaking the time string in JavaScript sounds like ...
8 years, 4 months ago (2012-08-03 23:52:24 UTC) #4
Yoshiki IGUCHI
Thanks for comment. I've updated the patch description and I'll commit it.
8 years, 4 months ago (2012-08-03 23:55:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/10852014/6002
8 years, 4 months ago (2012-08-04 18:20:59 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-04 18:37:06 UTC) #7
Try job failure for 10852014-6002 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698