Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 10852012: Fix lost context recreation race in BrowserGpuChannelHostFactory (Closed)

Created:
8 years, 4 months ago by piman
Modified:
8 years, 4 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Fix lost context recreation race in BrowserGpuChannelHostFactory An existing GPU process may have died between the last message we sent on its channel and the next time we try to establish a new GPU channel. In that case, we would re-use the GpuProcessHost but fail on the Send. When that happens, we want to retry with a fresh GPU process. BUG=129067 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -17 lines) Patch
M content/browser/gpu/browser_gpu_channel_host_factory.h View 2 chunks +7 lines, -4 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 4 chunks +34 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
piman
Note: I suspect we want some similar logic in GpuMessageFilter, though the race is much ...
8 years, 4 months ago (2012-08-03 22:16:55 UTC) #1
apatrick_chromium
lgtm
8 years, 4 months ago (2012-08-03 23:59:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10852012/1
8 years, 4 months ago (2012-08-04 00:17:54 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-04 01:27:08 UTC) #4
Change committed as 149993

Powered by Google App Engine
This is Rietveld 408576698