Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: chrome/test/pyautolib/pyautolib.cc

Issue 10852011: Fixed a bug where pyautolib.cc did not log the automation error message. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/pyautolib/pyautolib.cc
diff --git a/chrome/test/pyautolib/pyautolib.cc b/chrome/test/pyautolib/pyautolib.cc
index dace100a26b78b5103a6da8f1398267c49b00154..7eadbc9c85540481d4a3f9885702a45293e25ea0 100644
--- a/chrome/test/pyautolib/pyautolib.cc
+++ b/chrome/test/pyautolib/pyautolib.cc
@@ -305,11 +305,10 @@ void PyUITestBase::ErrorResponse(
const std::string& request,
std::string* response) {
base::DictionaryValue error_dict;
- LOG(ERROR) << "Error during automation: " << *response;
- error_dict.SetString("error",
- StringPrintf("%s for %s",
- error_string.c_str(),
- request.c_str()));
+ std::string error_msg = StringPrintf("%s for %s", error_string.c_str(),
+ request.c_str());
+ LOG(ERROR) << "Error during automation: " << error_msg;
+ error_dict.SetString("error", error_msg);
base::JSONWriter::Write(&error_dict, response);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698