Issue 10852005: SPDY - enable SpdyHttpStream tests undwer DrMemory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10852005: SPDY - enable SpdyHttpStream tests undwer DrMemory. (Closed)

Created:
8 years, 4 months ago by ramant (doing other things)

Modified:
8 years, 4 months ago

Reviewers:
Reid Kleckner, Reid Kleckner (google)

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

SPDY - Deleted SpdyHttpStream.* suppression from DrMemory. We had fixed race condition bugs with checnked upload in http://src.chromium.org/viewvc/chrome?view=rev&revision=146255 We had renamed all SpdyHttpStreamSpdyTest.* tests as SpdyHttpStreamSpdy2Test and SpdyHttpStreamSpdy3Test and the old suppression is not needed. We have been running SpdyHttpStreamSpdy*Test* for a while. R=rnk@chromium.org BUG=95007 TEST=valgrind unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150117

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

ramant (doing other things)

Hi Reid, We have been running SpdyHttpStreamSpdy2Test and SpdyHttpStreamSpdy3Test unit tests on Windows DrMemory tests. ...

8 years, 4 months ago (2012-08-03 18:18:29 UTC) #1

LGTM