In ExtensionDispatcher, maintain the active extensions as a subset of installed

In ExtensionDispatcher, maintain the active extensions as a subset of installed
extensions by removing them when extensions are uninstalled. Tweak several
defensive guards against this to be CHECKs.


BUG=139869
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149613

[Aaron Boodman, 2012-08-02 09:42:42]

https://chromiumcodereview.appspot.com/10851002/diff/1/chrome/renderer/extens...
File chrome/renderer/extensions/extension_dispatcher.cc (right):

https://chromiumcodereview.appspot.com/10851002/diff/1/chrome/renderer/extens...
chrome/renderer/extensions/extension_dispatcher.cc:1079: return
extensions_.Contains(extension_id) ?
Have you seen this continue to happen after the extension gets unloaded? It
seems like it shouldn't, but maybe it races.

[not at google - send to devlin, 2012-08-02 09:53:55]

https://chromiumcodereview.appspot.com/10851002/diff/1/chrome/renderer/extens...
File chrome/renderer/extensions/extension_dispatcher.cc (right):

https://chromiumcodereview.appspot.com/10851002/diff/1/chrome/renderer/extens...
chrome/renderer/extensions/extension_dispatcher.cc:1079: return
extensions_.Contains(extension_id) ?
On 2012/08/02 09:42:42, Aaron Boodman wrote:
> Have you seen this continue to happen after the extension gets unloaded? It
> seems like it shouldn't, but maybe it races.

No I haven't seen it. I could CHECK but I'm not 100% sure that it's valid and
it's so close to the branch point. Probably safe though.

[Aaron Boodman, 2012-08-02 10:13:17]

lgtm

[commit-bot: I haz the power, 2012-08-02 10:13:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/10851002/1

[commit-bot: I haz the power, 2012-08-02 11:52:10]

Change committed as 149613