Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 10850038: Drive: Add "Clear Local Cache" in the Gear menu to clear all local cache of Drive. (Closed)

Created:
8 years, 4 months ago by yoshiki
Modified:
8 years, 4 months ago
CC:
satorux1, chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Drive: Add "Clear Local Cache" in the Gear menu to clear all local cache of Drive. The menu item ("Clear Local Cache") is on the menu only when pressing Ctrl key, as discussed at crbug.com/135197. BUG=135197 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150034

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed the indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/css/file_manager.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 5 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yoshiki
kaznacheev: Could you take a look? fileBrowserPrivate.clearDriveCache, which is called in this CL, is under ...
8 years, 4 months ago (2012-08-03 07:50:12 UTC) #1
Vladislav Kaznacheev
LGTM with 1 comment addressed https://chromiumcodereview.appspot.com/10850038/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10850038/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode3235 chrome/browser/resources/file_manager/js/file_manager.js:3235: this.dialogDom_.setAttribute('ctrl-pressing', 'true'); Indentation
8 years, 4 months ago (2012-08-03 08:37:38 UTC) #2
yoshiki
Thank you for quick review! I'll commit this after the API part.
8 years, 4 months ago (2012-08-03 09:00:32 UTC) #3
yoshiki
Thank you for quick review! I'll commit this after the API part.
8 years, 4 months ago (2012-08-03 09:00:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/10850038/5001
8 years, 4 months ago (2012-08-04 18:20:33 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-05 00:30:02 UTC) #6
Change committed as 150034

Powered by Google App Engine
This is Rietveld 408576698