[cros] Add attribution (author & website) strings to stock user images.

[cros] Add attribution (author & website) strings to stock user images.


BUG=139401
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149969

[Nikita (slow), 2012-08-03 17:52:54]

lgtm

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe.css (right):

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.css:668: #user-image-attribution {
Seems that this one is not needed, in fact it is better to remove it to test
this code:

 $('user-image-attribution').style.visibility =
     (image.author || image.website) ? 'visible' : 'hidden';

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (right):

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:478:
$('user-image-author-name').textContent = image.author;
image.author / image.website might be undefined for G+ profile picture / camera
/ custom, right?

Add check for that.

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:553:
item.author = data.author;
Add check that data.author / data.website is defined.

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/op...
File chrome/browser/resources/options2/chromeos/set_wallpaper_options.html
(right):

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/op...
chrome/browser/resources/options2/chromeos/set_wallpaper_options.html:12: <span
id="wallpaper-attribution-label" i18n-content="setWallpaperAuthor"></span>
nit: 80 chars

[Ivan Korotkov, 2012-08-03 20:13:41]

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe.css (right):

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.css:668: #user-image-attribution {
On 2012/08/03 17:52:54, Nikita Kostylev wrote:
> Seems that this one is not needed, in fact it is better to remove it to test
> this code:
> 
>  $('user-image-attribution').style.visibility =
>      (image.author || image.website) ? 'visible' : 'hidden';

As explained offline, this is to disable it completely on OOBE.

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (right):

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:478:
$('user-image-author-name').textContent = image.author;
On 2012/08/03 17:52:54, Nikita Kostylev wrote:
> image.author / image.website might be undefined for G+ profile picture /
camera
> / custom, right?
> 
> Add check for that.

Done.

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:553:
item.author = data.author;
On 2012/08/03 17:52:54, Nikita Kostylev wrote:
> Add check that data.author / data.website is defined.

Done.

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/op...
File chrome/browser/resources/options2/chromeos/set_wallpaper_options.html
(right):

http://codereview.chromium.org/10850036/diff/3019/chrome/browser/resources/op...
chrome/browser/resources/options2/chromeos/set_wallpaper_options.html:12: <span
id="wallpaper-attribution-label" i18n-content="setWallpaperAuthor"></span>
On 2012/08/03 17:52:54, Nikita Kostylev wrote:
> nit: 80 chars

Done.

[commit-bot: I haz the power, 2012-08-03 21:36:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/10850036/10002

[commit-bot: I haz the power, 2012-08-03 23:28:38]

Try job failure for 10850036-10002 (retry) (retry) on win_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...