Issue 10850030: Do not wrap preprocessor lines in the generated JNI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10850030: Do not wrap preprocessor lines in the generated JNI. (Closed)

Created:
8 years, 4 months ago by Ted C

Modified:
8 years, 4 months ago

Reviewers:
joth, Yaron, bulach

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org, bulach

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not wrap preprocessor lines in the generated JNI. For classes with long package/class names, this can extend over 80 characters when preceded by a #ifndef, etc.. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149780

Patch Set 1 #

Patch Set 2 : Add unit test. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	base/android/jni_generator/jni_generator.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	base/android/jni_generator/jni_generator_tests.py	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ted C

On 2012/08/02 23:17:07, joth wrote: > could you add a test to jni_generator_tests.py? Thanks! Done

8 years, 4 months ago (2012-08-02 23:51:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10850030/3001

8 years, 4 months ago (2012-08-03 00:28:42 UTC) #5

lgtm, thanks!

Expand Messages | Collapse Messages