Allow spoken feedback to be routed to TTS extensions, not just built-in TTS.

Allow spoken feedback to be routed to TTS extensions, not just built-in TTS.

BUG=140248
TEST=Install pkidpnnapnfgjhfhkpmjpbckkbaodldb from the web store, wait for it to finish downloading voice data, then turn speech feedback on/off with Ctrl+Alt+Z and you should hear the high-quality voice.
TBR=derat
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150089

[dmazzoni, 2012-08-06 08:29:09]

Ping

On Thu, Aug 2, 2012 at 10:03 AM, <dmazzoni@chromium.org> wrote:

> Reviewers: Zachary Kuznia,
>
> Description:
> Allow spoken feedback to be routed to TTS extensions, not just built-in
> TTS.
>
> BUG=140248
> TEST=Install pkidpnnapnfgjhfhkpmjpbckkbaodl**db from the web store, wait
> for it to
> finish downloading voice data, then turn speech feedback on/off with
> Ctrl+Alt+Z
> and you should hear the high-quality voice.
>
> Please review this at
http://codereview.chromium.**org/10850018/<http://codereview.chromium.org/108...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>   M     chrome/browser/chromeos/**accessibility/accessibility_**util.cc
>
>
> Index: chrome/browser/chromeos/**accessibility/accessibility_**util.cc
> ==============================**==============================**=======
> --- chrome/browser/chromeos/**accessibility/accessibility_**util.cc
> (revision 148955)
> +++ chrome/browser/chromeos/**accessibility/accessibility_**util.cc
> (working copy)
> @@ -20,7 +20,7 @@
>  #include "chrome/browser/prefs/pref_**service.h"
>  #include "chrome/browser/profiles/**profile.h"
>  #include "chrome/browser/profiles/**profile_manager.h"
> -#include "chrome/browser/speech/**extension_api/tts_extension_**
> api_platform.h"
> +#include "chrome/browser/speech/**extension_api/tts_extension_**
> api_controller.h"
>  #include "chrome/common/extensions/**extension.h"
>  #include "chrome/common/extensions/**extension_messages.h"
>  #include "chrome/common/extensions/**extension_resource.h"
> @@ -197,13 +197,19 @@
>    EnableSpokenFeedback(spoken_**feedback_enabled, login_web_ui);
>  };
>
> -void Speak(const std::string& utterance) {
> +void Speak(const std::string& text) {
>    UtteranceContinuousParameters params;
> -  ExtensionTtsPlatformImpl::**GetInstance()->Speak(
> -      -1,  // No utterance ID because we don't need a callback when it
> finishes.
> -      utterance.c_str(),
> -      g_browser_process->**GetApplicationLocale(),
> -      params);
> +
> +  Profile* profile = ProfileManager::**GetDefaultProfile();
> +  Utterance* utterance = new Utterance(profile);
> +  utterance->set_text(text);
> +  utterance->set_lang(g_browser_**process->GetApplicationLocale(**));
> +  utterance->set_continuous_**parameters(params);
> +  utterance->set_can_enqueue(**false);
> +  utterance->set_options(new DictionaryValue());
> +
> +  ExtensionTtsController* controller = ExtensionTtsController::**
> GetInstance();
> +  controller->SpeakOrEnqueue(**utterance);
>  }
>
>  bool IsSpokenFeedbackEnabled() {
>
>
>

[Zachary Kuznia, 2012-08-06 08:34:27]

lgtm

[commit-bot: I haz the power, 2012-08-06 08:52:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/10850018/1

[commit-bot: I haz the power, 2012-08-06 09:11:16]

Try job failure for 10850018-1 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...