Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 10850006: Temporary fix for Mac black-screen issue. (Closed)

Created:
8 years, 4 months ago by Jamie
Modified:
8 years, 4 months ago
Reviewers:
Lambros
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Temporary fix for Mac black-screen issue. BUG=139930 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149522

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M remoting/host/video_frame_capturer_mac.mm View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jamie
For some reason, the undeprecated APIs that are intended to replace CGLSetFullScreen cause the display ...
8 years, 4 months ago (2012-08-01 20:57:28 UTC) #1
Lambros
lgtm with comment https://chromiumcodereview.appspot.com/10850006/diff/1/remoting/host/video_frame_capturer_mac.mm File remoting/host/video_frame_capturer_mac.mm (right): https://chromiumcodereview.appspot.com/10850006/diff/1/remoting/host/video_frame_capturer_mac.mm#newcode684 remoting/host/video_frame_capturer_mac.mm:684: CGLSetFullScreen(cgl_context_); Can you add a comment ...
8 years, 4 months ago (2012-08-01 21:03:45 UTC) #2
Jamie
fyi https://chromiumcodereview.appspot.com/10850006/diff/1/remoting/host/video_frame_capturer_mac.mm File remoting/host/video_frame_capturer_mac.mm (right): https://chromiumcodereview.appspot.com/10850006/diff/1/remoting/host/video_frame_capturer_mac.mm#newcode684 remoting/host/video_frame_capturer_mac.mm:684: CGLSetFullScreen(cgl_context_); On 2012/08/01 21:03:45, Lambros wrote: > Can ...
8 years, 4 months ago (2012-08-01 21:11:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/10850006/4001
8 years, 4 months ago (2012-08-01 21:12:49 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 22:39:59 UTC) #5
Change committed as 149522

Powered by Google App Engine
This is Rietveld 408576698