Upstream evaluateJavaScript

Upstream evaluateJavaScript

Added ContentViewCore.evaluateJavaScript and tied it into
ContentViewClient.onEvaluateJavaScriptResult.

BUG=http://crbug.com/139732


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149335

[David Trainor- moved to gerrit, 2012-07-31 17:18:42]

PTAL.

Jam if you're super busy feel free to just look at content_shell.gypi. 
Yaron/Ted, can you take a look at ContentViewCore/content_view_core_impl stuff?

[Yaron, 2012-07-31 18:10:12]

lgtm

[Ted C, 2012-07-31 18:15:48]

lgtm

https://chromiumcodereview.appspot.com/10848002/diff/1/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://chromiumcodereview.appspot.com/10848002/diff/1/content/public/android...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:756:
@SuppressWarnings("unused")
if this is non-private, I don't think you need the SuppressWarnings annotation.

[jam, 2012-07-31 18:20:44]

lgtm with nits

http://codereview.chromium.org/10848002/diff/1/content/browser/android/conten...
File content/browser/android/content_view_core_impl.cc (right):

http://codereview.chromium.org/10848002/diff/1/content/browser/android/conten...
content/browser/android/content_view_core_impl.cc:179: DCHECK(host);
nit: unnecessary, if null will crash right below

http://codereview.chromium.org/10848002/diff/1/content/browser/android/conten...
content/browser/android/content_view_core_impl.cc:450: (ContentViewCoreImpl*)
ContentViewCore::GetNativeContentViewCore(env,
google style is to not use c style casts. so use static_cast here

http://codereview.chromium.org/10848002/diff/1/content/browser/android/conten...
content/browser/android/content_view_core_impl.cc:452: DCHECK(view);
ditto

http://codereview.chromium.org/10848002/diff/1/content/browser/android/conten...
File content/browser/android/content_view_core_impl.h (right):

http://codereview.chromium.org/10848002/diff/1/content/browser/android/conten...
content/browser/android/content_view_core_impl.h:198:
content::NotificationRegistrar notification_registrar_;
content:: is unnecessary

[David Trainor- moved to gerrit, 2012-07-31 20:38:47]

https://chromiumcodereview.appspot.com/10848002/diff/1/content/browser/androi...
File content/browser/android/content_view_core_impl.cc (right):

https://chromiumcodereview.appspot.com/10848002/diff/1/content/browser/androi...
content/browser/android/content_view_core_impl.cc:179: DCHECK(host);
On 2012/07/31 18:20:44, John Abd-El-Malek wrote:
> nit: unnecessary, if null will crash right below

Done.

https://chromiumcodereview.appspot.com/10848002/diff/1/content/browser/androi...
content/browser/android/content_view_core_impl.cc:450: (ContentViewCoreImpl*)
ContentViewCore::GetNativeContentViewCore(env,
On 2012/07/31 18:20:44, John Abd-El-Malek wrote:
> google style is to not use c style casts. so use static_cast here

Done.

https://chromiumcodereview.appspot.com/10848002/diff/1/content/browser/androi...
content/browser/android/content_view_core_impl.cc:452: DCHECK(view);
On 2012/07/31 18:20:44, John Abd-El-Malek wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/10848002/diff/1/content/browser/androi...
File content/browser/android/content_view_core_impl.h (right):

https://chromiumcodereview.appspot.com/10848002/diff/1/content/browser/androi...
content/browser/android/content_view_core_impl.h:198:
content::NotificationRegistrar notification_registrar_;
On 2012/07/31 18:20:44, John Abd-El-Malek wrote:
> content:: is unnecessary

Done.

https://chromiumcodereview.appspot.com/10848002/diff/1/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://chromiumcodereview.appspot.com/10848002/diff/1/content/public/android...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:756:
@SuppressWarnings("unused")
On 2012/07/31 18:15:48, Ted C wrote:
> if this is non-private, I don't think you need the SuppressWarnings
annotation.

Made it private.

[commit-bot: I haz the power, 2012-07-31 21:57:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtrainor@chromium.org/10848002/13001

[commit-bot: I haz the power, 2012-08-01 00:43:47]

Change committed as 149335