Upstream CleanupReference

Upstream CleanupReference

Upstream CleanupReference.java and tie it into ContentViewCore.java and ContentSettings.java.

BUG=http://crbug.com/138482


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149496

[David Trainor- moved to gerrit, 2012-07-31 21:37:28]

PTAL

[Jesse Greenwald, 2012-07-31 21:45:17]

On 2012/07/31 21:37:28, dtrainor wrote:
> PTAL

LGTM

[joth, 2012-07-31 21:47:23]

lgtm

http://codereview.chromium.org/10846004/diff/3001/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/common/CleanupReference.java
(right):

http://codereview.chromium.org/10846004/diff/3001/content/public/android/java...
content/public/android/java/src/org/chromium/content/common/CleanupReference.java:11:

nit: spurious \n

http://codereview.chromium.org/10846004/diff/3001/content/public/android/java...
content/public/android/java/src/org/chromium/content/common/CleanupReference.java:90:
// busy to service messages) but we could investigate synchronously flush the
nit: flushing

[Yaron, 2012-07-31 23:33:05]

On 2012/07/31 21:47:23, joth wrote:
> lgtm
> 
>
http://codereview.chromium.org/10846004/diff/3001/content/public/android/java...
> File
>
content/public/android/java/src/org/chromium/content/common/CleanupReference.java
> (right):
> 
>
http://codereview.chromium.org/10846004/diff/3001/content/public/android/java...
>
content/public/android/java/src/org/chromium/content/common/CleanupReference.java:11:
> 
> nit: spurious \n
> 
>
http://codereview.chromium.org/10846004/diff/3001/content/public/android/java...
>
content/public/android/java/src/org/chromium/content/common/CleanupReference.java:90:
> // busy to service messages) but we could investigate synchronously flush the
> nit: flushing

rubberstamp lgtm

Has this been applied to all relevant classes downstream?

[David Trainor- moved to gerrit, 2012-08-01 18:12:21]

It's integrated into ContentViewCore and ContentSettings downstrea as well. 
I'll move the fixes here downstream after I land.

On 2012/07/31 23:33:05, Yaron wrote:
> On 2012/07/31 21:47:23, joth wrote:
> > lgtm
> > 
> >
>
http://codereview.chromium.org/10846004/diff/3001/content/public/android/java...
> > File
> >
>
content/public/android/java/src/org/chromium/content/common/CleanupReference.java
> > (right):
> > 
> >
>
http://codereview.chromium.org/10846004/diff/3001/content/public/android/java...
> >
>
content/public/android/java/src/org/chromium/content/common/CleanupReference.java:11:
> > 
> > nit: spurious \n
> > 
> >
>
http://codereview.chromium.org/10846004/diff/3001/content/public/android/java...
> >
>
content/public/android/java/src/org/chromium/content/common/CleanupReference.java:90:
> > // busy to service messages) but we could investigate synchronously flush
the
> > nit: flushing
> 
> rubberstamp lgtm
> 
> Has this been applied to all relevant classes downstream?

[David Trainor- moved to gerrit, 2012-08-01 18:15:44]

https://chromiumcodereview.appspot.com/10846004/diff/3001/content/public/andr...
File
content/public/android/java/src/org/chromium/content/common/CleanupReference.java
(right):

https://chromiumcodereview.appspot.com/10846004/diff/3001/content/public/andr...
content/public/android/java/src/org/chromium/content/common/CleanupReference.java:11:

On 2012/07/31 21:47:23, joth wrote:
> nit: spurious \n

Done.

https://chromiumcodereview.appspot.com/10846004/diff/3001/content/public/andr...
content/public/android/java/src/org/chromium/content/common/CleanupReference.java:90:
// busy to service messages) but we could investigate synchronously flush the
On 2012/07/31 21:47:23, joth wrote:
> nit: flushing

Done.

[commit-bot: I haz the power, 2012-08-01 20:15:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtrainor@chromium.org/10846004/9001

[commit-bot: I haz the power, 2012-08-01 21:35:07]

Change committed as 149496