Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 10846003: TSAN: Speculative fix for race errors in DeviceOrientationProviderTest. (Closed)

Created:
8 years, 4 months ago by Lei Zhang
Modified:
8 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, hans
Visibility:
Public.

Description

TSAN: Speculative fix for race errors in DeviceOrientationProviderTest. BUG=139849 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149276

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/browser/device_orientation/provider_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
8 years, 4 months ago (2012-07-31 18:45:00 UTC) #1
pivanof
FTR: multi-thread refcounting for MockOrientationFactory was introduced by me in https://chromiumcodereview.appspot.com/10835030/. I should have noticed ...
8 years, 4 months ago (2012-07-31 18:56:55 UTC) #2
piman
lgtm
8 years, 4 months ago (2012-07-31 18:58:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10846003/4001
8 years, 4 months ago (2012-07-31 19:00:05 UTC) #4
commit-bot: I haz the power
Try job failure for 10846003-4001 (retry) on mac_rel for steps "base_unittests, browser_tests, cacheinvalidation_unittests, jingle_unittests, remoting_unittests, ...
8 years, 4 months ago (2012-07-31 19:18:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10846003/4001
8 years, 4 months ago (2012-07-31 19:41:41 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 21:19:44 UTC) #7
Change committed as 149276

Powered by Google App Engine
This is Rietveld 408576698