Regression test for lack of errors on requests with invalid ports

Regression test for lack of errors on requests with invalid ports

This cl introduces a regression test for bug 138745, in which the
ftp_protocol_handler did not correctly return errors on requests with invalid
ports.

This bug was fixed in
http://codereview.chromium.org/10834053/

BUG=http://code.google.com/p/chromium/issues/detail?id=138735


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150050

[shalev, 2012-08-02 18:20:23]

Hi Matt,

This is a regression test for the bug you discovered in the
ftp_protocol_handler. The bug is already fixed.

Please take a look.

Shalev

[mmenke, 2012-08-03 15:40:53]

Sorry, forgot to publish my comments.  LGTM, with comments addressed.

http://codereview.chromium.org/10844004/diff/1/net/url_request/url_request_un...
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/10844004/diff/1/net/url_request/url_request_un...
net/url_request/url_request_unittest.cc:4116: TEST_F(URLRequestTestFTP, Errors)
{
Think it's best to document even fairly straightforward tests.  Maybe just
something along the liens of "Make sure an FTP request using an unsafe ports
fails."

http://codereview.chromium.org/10844004/diff/1/net/url_request/url_request_un...
net/url_request/url_request_unittest.cc:4116: TEST_F(URLRequestTestFTP, Errors)
{
Think "UnsafePort" would be a clearer name.

[commit-bot: I haz the power, 2012-08-05 07:12:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shalev@chromium.org/10844004/5001

[shalev, 2012-08-05 07:12:55]

http://codereview.chromium.org/10844004/diff/1/net/url_request/url_request_un...
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/10844004/diff/1/net/url_request/url_request_un...
net/url_request/url_request_unittest.cc:4116: TEST_F(URLRequestTestFTP, Errors)
{
On 2012/08/03 15:40:54, Matt Menke wrote:
> Think it's best to document even fairly straightforward tests.  Maybe just
> something along the liens of "Make sure an FTP request using an unsafe ports
> fails."

Done.

http://codereview.chromium.org/10844004/diff/1/net/url_request/url_request_un...
net/url_request/url_request_unittest.cc:4116: TEST_F(URLRequestTestFTP, Errors)
{
On 2012/08/03 15:40:54, Matt Menke wrote:
> Think "UnsafePort" would be a clearer name.

Done.

[commit-bot: I haz the power, 2012-08-05 16:44:10]

Change committed as 150050