Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 10844003: Fixing a couple of issues in sandbox::RestrictedToken: (Closed)

Created:
8 years, 4 months ago by alexeypa (please no reviews)
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fixing a couple of issues in sandbox::RestrictedToken: - Specify access bits on the duplicated handle correctly. - Avoid touching an uninitialized buffer in case of an error. BUG=139841 TEST=RestrictedTokenTest.DenyOwnerSidCustom, RestrictedTokenTest.AddRestrictingSidCurrentUserCustom Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149475

Patch Set 1 #

Patch Set 2 : Added unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -11 lines) Patch
M sandbox/win/src/restricted_token.cc View 4 chunks +17 lines, -11 lines 0 comments Download
M sandbox/win/src/restricted_token_unittest.cc View 1 2 chunks +63 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
alexeypa (please no reviews)
I've run into a couple of apparent issues in sandbox::RestrictedToken. Please take a look at ...
8 years, 4 months ago (2012-07-31 17:46:24 UTC) #1
rvargas (doing something else)
bug #? (for the DuplicateHandle)
8 years, 4 months ago (2012-07-31 17:59:07 UTC) #2
alexeypa (please no reviews)
On 2012/07/31 17:59:07, rvargas wrote: > bug #? (for the DuplicateHandle) I have filed http://crbug.com/139841.
8 years, 4 months ago (2012-07-31 18:07:14 UTC) #3
alexeypa (please no reviews)
On 2012/07/31 18:07:14, alexeypa wrote: > On 2012/07/31 17:59:07, rvargas wrote: > > bug #? ...
8 years, 4 months ago (2012-08-01 18:09:10 UTC) #4
rvargas (doing something else)
LGTM
8 years, 4 months ago (2012-08-01 18:38:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10844003/5001
8 years, 4 months ago (2012-08-01 18:45:30 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm
8 years, 4 months ago (2012-08-01 19:40:33 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 20:00:07 UTC) #8
Change committed as 149475

Powered by Google App Engine
This is Rietveld 408576698