Remove superfluous pruned paths from license tool

Remove superfluous pruned paths from license tool

These paths either no longer exist on any platform, or don't cause license
errors.

BUG=138921
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150328

[Nico, 2012-08-04 21:40:15]

I think most of them are still needed.

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py
File tools/licenses.py (left):

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py#oldcode32
tools/licenses.py:32: os.path.join('googleurl','third_party','icu'),
Sounds like a bug that this doesn't cause license errors, as it's in a
third_party folder without a LICENSE / README.chromium?

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py#oldcode45
tools/licenses.py:45: os.path.join('o3d','samples'),
This one's ok, we removed o3d a while ago.

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py#oldcode57
tools/licenses.py:57: os.path.join('third_party','valgrind'),
This is checked out only on the valgrind bots, so we probably want to keep this?

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py#oldcode64
tools/licenses.py:64: os.path.join('third_party','android_testrunner'),
This is probably checked out on the android bots, but not sure.

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py#oldcode84
tools/licenses.py:84: os.path.join('third_party','platformsdk_win7'),
This is checked out for people who map src-internal on windows (e.g. windows
bots)

[Steve Block, 2012-08-06 11:14:28]

Thanks!

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py
File tools/licenses.py (left):

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py#oldcode32
tools/licenses.py:32: os.path.join('googleurl','third_party','icu'),
We don't need this as we now check src/googleurl as an additional path, and the
tool doesn't check child directories.

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py#oldcode57
tools/licenses.py:57: os.path.join('third_party','valgrind'),
Ah, I see. Where is that specified? I didn't see anything in DEPS.

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py#oldcode64
tools/licenses.py:64: os.path.join('third_party','android_testrunner'),
Yes, it is, but the metadata is all good.

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py#oldcode84
tools/licenses.py:84: os.path.join('third_party','platformsdk_win7'),
OK

[Nico, 2012-08-06 23:54:24]

lgtm

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py
File tools/licenses.py (left):

http://codereview.chromium.org/10843069/diff/1/tools/licenses.py#oldcode57
tools/licenses.py:57: os.path.join('third_party','valgrind'),
On 2012/08/06 11:14:28, Steve Block wrote:
> Ah, I see. Where is that specified? I didn't see anything in DEPS.

http://www.chromium.org/developers/how-tos/using-valgrind

I think the valgrind bots have special deps somewhere else?

[commit-bot: I haz the power, 2012-08-07 09:52:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/steveblock@chromium.org/10843069/4001

[commit-bot: I haz the power, 2012-08-07 11:21:08]

Change committed as 150328