Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10843065: Add condition attribute for MIME media types from Content-Type header. (Closed)

Created:
8 years, 4 months ago by Yoyo Zhou
Modified:
8 years, 4 months ago
Reviewers:
battre
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add condition attribute for MIME media types from Content-Type header. This only supports positive tests. BUG=112155 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150126

Patch Set 1 #

Total comments: 2

Patch Set 2 : ; #

Patch Set 3 : missingtest #

Patch Set 4 : rebase #

Patch Set 5 : sittin' on the docs of the bay #

Patch Set 6 : with correct base #

Patch Set 7 : dammit docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -13 lines) Patch
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.h View 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h View 5 2 chunks +32 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc View 5 6 chunks +90 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 1 2 5 3 chunks +57 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_constants.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_constants.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/declarative_web_request.json View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/declarativeWebRequest.html View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webrequest/declarative/headers.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webrequest/declarative/headers.html.mock-http-headers View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/webrequest/test_declarative.js View 1 2 3 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yoyo Zhou
8 years, 4 months ago (2012-08-03 09:52:22 UTC) #1
battre
lgtm http://codereview.chromium.org/10843065/diff/1/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc File chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc (right): http://codereview.chromium.org/10843065/diff/1/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc#newcode49 chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc:49: // TODO(yoz): another one for content type want ...
8 years, 4 months ago (2012-08-03 11:37:04 UTC) #2
Yoyo Zhou
http://codereview.chromium.org/10843065/diff/1/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc File chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc (right): http://codereview.chromium.org/10843065/diff/1/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc#newcode49 chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc:49: // TODO(yoz): another one for content type On 2012/08/03 ...
8 years, 4 months ago (2012-08-03 11:48:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/10843065/13030
8 years, 4 months ago (2012-08-03 22:06:23 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/docs/apps/mediaGalleries.html: While running patch -p1 --forward --force; patching file chrome/common/extensions/docs/apps/mediaGalleries.html ...
8 years, 4 months ago (2012-08-03 22:06:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/10843065/9003
8 years, 4 months ago (2012-08-06 15:19:46 UTC) #6
commit-bot: I haz the power
Try job failure for 10843065-9003 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 15:39:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/10843065/9003
8 years, 4 months ago (2012-08-06 16:33:41 UTC) #8
commit-bot: I haz the power
Try job failure for 10843065-9003 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-06 19:06:28 UTC) #9
battre
8 years, 4 months ago (2012-08-06 19:30:08 UTC) #10 
On 2012/08/06 19:06:28, I haz the power (commit-bot) wrote:
> Try job failure for 10843065-9003 (retry) on win_rel for step "browser_tests".
> It's a second try, previously, step "browser_tests" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Hi Yoyo,

did you see this?


Note: Google Test filter = ExtensionWebRequestApiTest.WebRequestDeclarative
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExtensionWebRequestApiTest, where TypeParam = 
[ RUN      ] ExtensionWebRequestApiTest.WebRequestDeclarative
[2096:2600:0806/115849:165783401:INFO:CONSOLE(88)] "[FAIL] testCancelRequest:
uncaught exception: Error: Invalid value for argument 1. Property 'contentType':
Unexpected property.
[object Object]
    at Object.chrome.test.runNextTest (apitest:74:21)
    at Object.chrome.test.runTests (apitest:269:17)
    at Object.callback
(chrome-extension://cicklddkpkjojmhldcenifhnfoicimnb/framework.js:34:19)
    at Object.chromeHidden.handleResponse (sendRequest:49:24)", source: apitest
(88)
[2096:2600:0806/115849:165783416:INFO:CONSOLE(93)] "Uncaught
chrome.test.failure", source: apitest (93)
[2096:2600:0806/115849:165783604:INFO:CONSOLE(97)] "[SUCCESS]
testRedirectRequest", source: apitest (97)
[2096:2600:0806/115849:165783744:INFO:CONSOLE(97)] "[SUCCESS]
testRedirectRequest2", source: apitest (97)
[2096:2600:0806/115849:165783838:INFO:CONSOLE(97)] "[SUCCESS]
testRedirectByRegEx", source: apitest (97)
[2096:2600:0806/115850:165784103:INFO:CONSOLE(97)] "[SUCCESS]
testSetRequestHeader", source: apitest (97)
[2096:2600:0806/115850:165784243:INFO:CONSOLE(97)] "[SUCCESS]
testRemoveRequestHeader", source: apitest (97)
[2096:2600:0806/115850:165784352:INFO:CONSOLE(97)] "[SUCCESS]
testAddResponseHeader", source: apitest (97)
[2096:2600:0806/115850:165784462:INFO:CONSOLE(97)] "[SUCCESS]
testRemoveResponseHeader", source: apitest (97)
[2096:2600:0806/115850:165784571:INFO:CONSOLE(97)] "[SUCCESS] testPriorities",
source: apitest (97)
[2096:2600:0806/115850:165784742:INFO:CONSOLE(97)] "[SUCCESS]
testEditRequestCookies", source: apitest (97)
[2096:2600:0806/115851:165784867:INFO:CONSOLE(97)] "[SUCCESS]
testEditResponseCookies", source: apitest (97)
[2096:2600:0806/115851:165785008:INFO:CONSOLE(97)] "[SUCCESS] testPermission",
source: apitest (97)
[2096:2600:0806/115851:165785008:INFO:CONSOLE(40)] "Uncaught completed", source:
apitest (40)
E:\b\build\slave\win\build\src\chrome\browser\extensions\api\web_request\web_request_apitest.cc(140):
error: Value of: RunExtensionSubtest("webrequest", "test_declarative.html")
  Actual: false
Expected: true
Failed 1 of 12 tests
[  FAILED  ] ExtensionWebRequestApiTest.WebRequestDeclarative, where TypeParam =
 and GetParam() =  (3706 ms)
[----------] 1 test from ExtensionWebRequestApiTest (3706 ms total)

Strange that it happens only on windows, but it affects exactly the new code.

Best regards,
Dominic

Powered by Google App Engine
This is Rietveld 408576698