Issue 10843063: Promo for buying Drive storage when you're low on space

Issue 10843063: Promo for buying Drive storage when you're low on space (Closed)

Created:
8 years, 4 months ago by Vladislav Kaznacheev

Modified:
8 years, 4 months ago

Reviewers:
SeRya

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Promo for buying Drive storage when you're low on space BUG=137515 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149833

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -17 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/css/file_manager.css	View	1	1 chunk	+37 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View		3 chunks	+87 lines, -17 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

Please review. We want this done in M22, so the implementation is the most basic. ...

8 years, 4 months ago (2012-08-03 09:31:39 UTC) #1

SeRya

lgtm https://chromiumcodereview.appspot.com/10843063/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://chromiumcodereview.appspot.com/10843063/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode601 chrome/browser/resources/file_manager/css/file_manager.css:601: border-top: 1px solid rgba(0,0,0,0.1); Spaces after comma https://chromiumcodereview.appspot.com/10843063/diff/1/chrome/browser/resources/file_manager/js/file_manager.js ...

8 years, 4 months ago (2012-08-03 10:12:53 UTC) #2

Vladislav Kaznacheev

8 years, 4 months ago (2012-08-03 10:17:49 UTC) #3

https://chromiumcodereview.appspot.com/10843063/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

https://chromiumcodereview.appspot.com/10843063/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/css/file_manager.css:601: border-top: 1px
solid rgba(0,0,0,0.1);
On 2012/08/03 10:12:53, SeRya wrote:
> Spaces after comma

Done.

https://chromiumcodereview.appspot.com/10843063/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10843063/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:2971:
this.requestResize_(100);
There is a check at line 2940 that ensures that.

On 2012/08/03 10:12:53, SeRya wrote:
> Don't requestResize if nothing changed. It's an expensive operation.

Expand Messages | Collapse Messages