Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 10843061: [CrOS] Enumerate existing mount points and check for media devices. (Closed)

Created:
8 years, 4 months ago by kmadhusu
Modified:
8 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

[CrOS] Enumerate existing mount points and check for media devices. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149812

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/media_gallery/media_device_notifications_chromeos.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/media_gallery/media_device_notifications_chromeos.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kmadhusu
thestig@: When you get a chance, Can you please test this code on CrOS, just ...
8 years, 4 months ago (2012-08-03 06:16:24 UTC) #1
Lei Zhang
lgtm https://chromiumcodereview.appspot.com/10843061/diff/1/chrome/browser/media_gallery/media_device_notifications_chromeos.h File chrome/browser/media_gallery/media_device_notifications_chromeos.h (right): https://chromiumcodereview.appspot.com/10843061/diff/1/chrome/browser/media_gallery/media_device_notifications_chromeos.h#newcode51 chrome/browser/media_gallery/media_device_notifications_chromeos.h:51: void CheckExistingMountPoints(); How about: // Checks existing mount ...
8 years, 4 months ago (2012-08-03 06:24:19 UTC) #2
kmadhusu
Addressed comment. Thanks. https://chromiumcodereview.appspot.com/10843061/diff/1/chrome/browser/media_gallery/media_device_notifications_chromeos.h File chrome/browser/media_gallery/media_device_notifications_chromeos.h (right): https://chromiumcodereview.appspot.com/10843061/diff/1/chrome/browser/media_gallery/media_device_notifications_chromeos.h#newcode51 chrome/browser/media_gallery/media_device_notifications_chromeos.h:51: void CheckExistingMountPoints(); On 2012/08/03 06:24:19, Lei ...
8 years, 4 months ago (2012-08-03 06:37:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10843061/5001
8 years, 4 months ago (2012-08-03 06:37:23 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 08:07:16 UTC) #5
Change committed as 149812

Powered by Google App Engine
This is Rietveld 408576698