Issue 10843060: views: Fix gesture event propagation in menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10843060: views: Fix gesture event propagation in menus. (Closed)

Created:
8 years, 4 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

views: Fix gesture event propagation in menus. BUG=136931 TEST=open wrench menu and tap on one of the zoom buttons Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149882

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -20 lines)			Patch
	M	chrome/browser/ui/views/wrench_menu.cc	View	1	11 chunks	+28 lines, -20 lines	0 comments	Download
	M	ui/views/controls/menu/menu_host_root_view.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

sadrul

The main change is in MenuHostRootView, which needs to send the gesture event through RootView ...

8 years, 4 months ago (2012-08-03 03:36:28 UTC) #1

lgtm