Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: vm/object.h

Issue 10843053: Improve the error message for handle check failure to list the actual (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/object.h
===================================================================
--- vm/object.h (revision 10240)
+++ vm/object.h (working copy)
@@ -62,7 +62,8 @@
reinterpret_cast<object*>(VMHandles::AllocateHandle(isolate)); \
initializeHandle(obj, raw_ptr); \
if (!obj->Is##object()) { \
- FATAL("Handle check failed."); \
+ FATAL2("Handle check failed: saw %s expected %s", \
+ obj->ToCString(), #object); \
} \
return *obj; \
} \
@@ -86,7 +87,8 @@
VMHandles::AllocateZoneHandle(isolate)); \
initializeHandle(obj, raw_ptr); \
if (!obj->Is##object()) { \
- FATAL("Handle check failed."); \
+ FATAL2("Handle check failed: saw %s expected %s", \
+ obj->ToCString(), #object); \
} \
return *obj; \
} \
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698