Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 10843045: Move "Accessibility features are enabled." string resource from chrome/ to ash/ (Closed)

Created:
8 years, 4 months ago by hashimoto
Modified:
8 years, 4 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Move "Accessibility features are enabled." string resource from chrome/ to ash/ BUG=140060 TEST=Press Ctrl+Alt+Z to enable spoken feedback, see a bubble "Accessibility features are enabled…" is shown. TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149800

Patch Set 1 : _ #

Patch Set 2 : Split ash_string.grd change to another CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M ash/system/tray_accessibility.h View 2 chunks +3 lines, -7 lines 0 comments Download
M ash/system/tray_accessibility.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
8 years, 4 months ago (2012-08-02 07:39:25 UTC) #1
Zachary Kuznia
On 2012/08/02 07:39:25, hashimoto wrote: LGTM
8 years, 4 months ago (2012-08-02 07:49:28 UTC) #2
hashimoto
On 2012/08/02 07:49:28, Zachary Kuznia wrote: > On 2012/08/02 07:39:25, hashimoto wrote: > > LGTM ...
8 years, 4 months ago (2012-08-02 07:57:19 UTC) #3
hashimoto
sadrul, could you review ash/system/ as an owner? ben, could you review chrome/browser/chromeos/system/ash_system_tray_delegate.cc as an ...
8 years, 4 months ago (2012-08-02 08:05:24 UTC) #4
sadrul
LGTM
8 years, 4 months ago (2012-08-02 08:06:51 UTC) #5
hashimoto
TBR-ing ben@chromium.org
8 years, 4 months ago (2012-08-03 05:22:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10843045/7002
8 years, 4 months ago (2012-08-03 05:22:46 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 07:22:41 UTC) #8
Change committed as 149800

Powered by Google App Engine
This is Rietveld 408576698