Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 10843044: Fix sourceAbort() for BMFF streams. (Closed)

Created:
8 years, 4 months ago by strobe_
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix sourceAbort() for BMFF streams. MP4StreamParser::Flush() (called eventually by sourceAbort()) did not reset the parser state, and so would only work if the call happened to come when the parser was already in a particular state (which happened to always be true for the browser test harness it was originally tested with). Additionally, the format-specific buffer conversion methods did not cause an error to be propagated to the caller on failure, resulting in unexpected success for the added test. BUG= TEST=MP4StreamParserTest.TestFlush Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M media/mp4/mp4_stream_parser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/mp4/mp4_stream_parser.cc View 4 chunks +21 lines, -9 lines 0 comments Download
M media/mp4/mp4_stream_parser_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
strobe_
8 years, 4 months ago (2012-08-02 07:21:02 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM
8 years, 4 months ago (2012-08-02 20:23:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/strobe@google.com/10843044/1
8 years, 4 months ago (2012-08-02 21:39:02 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 22:54:36 UTC) #4
Change committed as 149730

Powered by Google App Engine
This is Rietveld 408576698