Issue 10843043: gdata: Make WeakPtrFactory the last parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10843043: gdata: Make WeakPtrFactory the last parameter (Closed)

Created:
8 years, 4 months ago by satorux1

Modified:
8 years, 4 months ago

Reviewers:
kinaba

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Make WeakPtrFactory the last parameter This is a reland of r149576, which was reverted as it broke RemoteFileSystemExtensionApiTest.RemoteMountPoint. Turned out that ui_weak_ptr_ in GDataFileSystem shouldn't be removed. Remove WeakPtr members in favor of WeakPtrFactory::GetWeakPtr() Along the way, copy derat's comment from ContactDatabase on this matter. Wez on [chromium-dev] Weak ptrs for derived types? You need to be similarly careful to have WeakPtrFactory appear after any fields that its WeakPtrs may be used to access if you follow that pattern instead. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149585

Patch Set 1 #

Patch Set 2 : fix #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -37 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_auth_service.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_auth_service.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache.h	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache.cc	View		5 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_download_observer.h	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_operation_runner.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_operation_runner.cc	View		3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_sync_client.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_uploader.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_uploader.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/operations_base.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

"Patch Set 1" contains the original patch that was reverted.

8 years, 4 months ago (2012-08-02 06:50:13 UTC) #2

lgtm

Expand Messages | Collapse Messages