Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 10843034: Fix license for xdg_mime (Closed)

Created:
8 years, 4 months ago by Steve Block
Modified:
8 years, 4 months ago
Reviewers:
Mark Mentovai, agl
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Fix license for xdg_mime It looks like the existing MIT license was added incorrectly in http://codereview.chromium.org/1121003. The README file and source headers state that the correct license is Academic Free License version 2.0 or LGPL v2. BUG=138921 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149709

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -18 lines) Patch
M base/third_party/xdg_mime/LICENSE View 1 1 chunk +168 lines, -17 lines 0 comments Download
M base/third_party/xdg_mime/README.chromium View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Steve Block
8 years, 4 months ago (2012-08-01 18:02:49 UTC) #1
agl
lgtm
8 years, 4 months ago (2012-08-01 18:06:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/10843034/1
8 years, 4 months ago (2012-08-01 18:07:00 UTC) #3
commit-bot: I haz the power
Presubmit check for 10843034-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-01 18:07:02 UTC) #4
Steve Block
+mark for OWNERS
8 years, 4 months ago (2012-08-01 18:07:40 UTC) #5
Mark Mentovai
http://codereview.chromium.org/10843034/diff/1/base/third_party/xdg_mime/LICENSE File base/third_party/xdg_mime/LICENSE (right): http://codereview.chromium.org/10843034/diff/1/base/third_party/xdg_mime/LICENSE#newcode1 base/third_party/xdg_mime/LICENSE:1: Licensed under the Academic Free License version 2.0 Where ...
8 years, 4 months ago (2012-08-01 18:16:13 UTC) #6
Steve Block
http://codereview.chromium.org/10843034/diff/1/base/third_party/xdg_mime/LICENSE File base/third_party/xdg_mime/LICENSE (right): http://codereview.chromium.org/10843034/diff/1/base/third_party/xdg_mime/LICENSE#newcode1 base/third_party/xdg_mime/LICENSE:1: Licensed under the Academic Free License version 2.0 Yes, ...
8 years, 4 months ago (2012-08-01 19:12:38 UTC) #7
Mark Mentovai
LGTM
8 years, 4 months ago (2012-08-01 21:11:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/10843034/7001
8 years, 4 months ago (2012-08-02 19:58:22 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 21:49:46 UTC) #10
Change committed as 149709

Powered by Google App Engine
This is Rietveld 408576698