Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10843029: Fix some clang errors on Android. (Closed)

Created:
8 years, 4 months ago by nilesh
Modified:
8 years, 4 months ago
CC:
chromium-reviews, erikwright (departed), Aaron Boodman, mihaip-chromium-reviews_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix some clang errors on Android. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149498

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M base/test/test_support_android.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui_android.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_processes_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
nilesh
Mark: Please look at base/ Yoz: Please look at chrome/browser/extensions/ Thanks.
8 years, 4 months ago (2012-08-01 16:33:15 UTC) #1
Mark Mentovai
LGTM
8 years, 4 months ago (2012-08-01 16:35:30 UTC) #2
Mark Mentovai
https://chromiumcodereview.appspot.com/10843029/diff/1/chrome/browser/extensions/extension_processes_api.cc File chrome/browser/extensions/extension_processes_api.cc (right): https://chromiumcodereview.appspot.com/10843029/diff/1/chrome/browser/extensions/extension_processes_api.cc#newcode656 chrome/browser/extensions/extension_processes_api.cc:656: : memory_(false) { Fix indentation. See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constructor_Initializer_Lists#Constructor_Initializer_Lists .
8 years, 4 months ago (2012-08-01 16:36:20 UTC) #3
nilesh
https://chromiumcodereview.appspot.com/10843029/diff/1/chrome/browser/extensions/extension_processes_api.cc File chrome/browser/extensions/extension_processes_api.cc (right): https://chromiumcodereview.appspot.com/10843029/diff/1/chrome/browser/extensions/extension_processes_api.cc#newcode656 chrome/browser/extensions/extension_processes_api.cc:656: : memory_(false) { On 2012/08/01 16:36:20, Mark Mentovai wrote: ...
8 years, 4 months ago (2012-08-01 16:40:52 UTC) #4
Yoyo Zhou
LGTM
8 years, 4 months ago (2012-08-01 20:06:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10843029/7002
8 years, 4 months ago (2012-08-01 20:13:56 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 21:40:16 UTC) #7 
Change committed as 149498

Powered by Google App Engine
This is Rietveld 408576698