Issue 10843021: [pyauto] Add ability to specify @SUITE_NAME on command line

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10843021: [pyauto] Add ability to specify @SUITE_NAME on command line (Closed)

Created:
8 years, 4 months ago by Nirnimesh

Modified:
8 years, 4 months ago

Reviewers:
dennis_jeffrey

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[pyauto] Add ability to specify @SUITE_NAME on command line Also, remove --list-missing-tests. It was not used much. BUG=None TEST=python pyauto_functional.py @CONTINUOUS R=dennisjeffrey@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149447

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -33 lines)			Patch
	M	chrome/test/pyautolib/pyauto.py	View		5 chunks	+26 lines, -33 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dennis_jeffrey

8 years, 4 months ago (2012-08-01 01:23:27 UTC) #2

LGTM with 2 nits to consider before submitting.

https://chromiumcodereview.appspot.com/10843021/diff/1/chrome/test/pyautolib/...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10843021/diff/1/chrome/test/pyautolib/...
chrome/test/pyautolib/pyauto.py:6350: args =
_TestsFromDescriptionFile(self._options.suite)
suite=self._options.suite (or else remove default value for the parameter in the
function at line 6333 above)

https://chromiumcodereview.appspot.com/10843021/diff/1/chrome/test/pyautolib/...
chrome/test/pyautolib/pyauto.py:6356: out_args +=
_TestsFromDescriptionFile(suite)
similar comment as line 6350 above

Expand Messages | Collapse Messages