Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10843018: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed)

Created:
8 years, 4 months ago by rpetterson
Modified:
8 years, 4 months ago
Reviewers:
michaelbai
CC:
chromium-reviews, brettw-cc_chromium.org, sky
Visibility:
Public.

Description

Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. BUG=112525 TEST=unittests, manual TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/history/android/android_provider_backend_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rpetterson
sky TBR'd for owner approval
8 years, 4 months ago (2012-07-31 23:27:34 UTC) #1
michaelbai
LGTM, thanks for handling this.
8 years, 4 months ago (2012-07-31 23:39:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10843018/1
8 years, 4 months ago (2012-08-01 22:28:19 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 23:49:19 UTC) #4
Change committed as 149535

Powered by Google App Engine
This is Rietveld 408576698