Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Issue 10843017: PPAPI/NaCl: Restrict ppapi messages to unblock only ppapi (Closed)

Created:
8 years, 4 months ago by dmichael (off chromium)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, bbudge
Visibility:
Public.

Description

PPAPI/NaCl: Restrict ppapi messages to unblock only ppapi Currently, we don't tell the HostDispatcher to only unblock pepper messages when an incoming "unblock" pepper message comes in. This results in us unblocking non-pepper messages improperly (such as GPU messages). BUG=116317 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149451

Patch Set 1 #

Patch Set 2 : Move RendererRestrictDispatchGroup to content/renderer/public #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -29 lines) Patch
M chrome/renderer/pepper/ppb_nacl_private_impl.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
A + content/public/renderer/renderer_restrict_dispatch_group.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_broker_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
D content/renderer/renderer_restrict_dispatch_group.h View 1 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dmichael (off chromium)
Should be easy... basically just something we forgot to copy/paste from pepper_plugin_delegate_impl.cc, though I added ...
8 years, 4 months ago (2012-07-31 22:26:32 UTC) #1
brettw
lgtm
8 years, 4 months ago (2012-07-31 22:30:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/10843017/1
8 years, 4 months ago (2012-07-31 22:34:10 UTC) #3
commit-bot: I haz the power
Presubmit check for 10843017-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-31 22:34:15 UTC) #4
dmichael(do not use this one)
On Tue, Jul 31, 2012 at 4:34 PM, <commit-bot@chromium.org> wrote: > Presubmit check for 10843017-1 ...
8 years, 4 months ago (2012-07-31 22:40:50 UTC) #5
bbudge
LGTM. Brett is fixing his machine so you might want to TBR him.
8 years, 4 months ago (2012-07-31 22:42:06 UTC) #6
brettw
Talked with John and he's OK moving this file to public.
8 years, 4 months ago (2012-07-31 22:50:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/10843017/8001
8 years, 4 months ago (2012-08-01 15:51:15 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 18:35:02 UTC) #9
Change committed as 149451

Powered by Google App Engine
This is Rietveld 408576698