Issue 10843005: Polished file error messages for the Files app

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10843005: Polished file error messages for the Files app (Closed)

Created:
8 years, 4 months ago by Vladislav Kaznacheev

Modified:
8 years, 4 months ago

Reviewers:
Oleg Eterevsky

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Polished file error messages for the Files app BUG=138009 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149169

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	chrome/app/generated_resources.grd	View		2 chunks	+3 lines, -3 lines	1 comment	Download
	M	chrome/browser/resources/file_manager/js/file_manager.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Oleg Eterevsky

LGTM https://chromiumcodereview.appspot.com/10843005/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/10843005/diff/1/chrome/app/generated_resources.grd#newcode11503 chrome/app/generated_resources.grd:11503: + <message name="IDS_FILE_BROWSER_FILE_ERROR_INVALID_STATE" desc="In the File Manager, the ...

8 years, 4 months ago (2012-07-31 11:01:10 UTC) #2

commit-bot: I haz the power

8 years, 4 months ago (2012-07-31 11:18:50 UTC) #3

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Expand Messages | Collapse Messages