Override the framework path in PreSandboxStartup.

Override the framework path in PreSandboxStartup.

BasicStartupComplete is not invoked for browser tests

BUG=none
TEST=no complaints about MainMenu not found when running content_browsertests on mac


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149197

[jochen (gone - plz use gerrit), 2012-07-31 09:44:13]

plz review

[Avi (use Gerrit), 2012-07-31 14:54:58]

lgtm

https://chromiumcodereview.appspot.com/10843003/diff/1/content/shell/shell_ma...
File content/shell/shell_main_delegate.cc (right):

https://chromiumcodereview.appspot.com/10843003/diff/1/content/shell/shell_ma...
content/shell/shell_main_delegate.cc:70: OverrideFrameworkBundlePath();
Note that the location of this call was mirroring its location in Chrome. Do we
want to move it in Chrome too to match?

[jochen (gone - plz use gerrit), 2012-07-31 14:59:26]

https://chromiumcodereview.appspot.com/10843003/diff/1/content/shell/shell_ma...
File content/shell/shell_main_delegate.cc (right):

https://chromiumcodereview.appspot.com/10843003/diff/1/content/shell/shell_ma...
content/shell/shell_main_delegate.cc:70: OverrideFrameworkBundlePath();
On 2012/07/31 14:54:58, Avi wrote:
> Note that the location of this call was mirroring its location in Chrome. Do
we
> want to move it in Chrome too to match?

I don't know why it's called there.

The problem is that ContentBrowserTest::SetUp only invokes PreSandboxStartup,
but not BasicStartupComplete

[commit-bot: I haz the power, 2012-07-31 15:05:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/10843003/1

[commit-bot: I haz the power, 2012-07-31 16:23:09]

Change committed as 149197