Issue 10839003: Pass enable_themes to grit and use for html conditions regarding themes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10839003: Pass enable_themes to grit and use for html conditions regarding themes. (Closed)

Created:
8 years, 4 months ago by flackr

Modified:
8 years, 4 months ago

Reviewers:
Ted C, Dan Beam

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Pass enable_themes to grit and use for html conditions regarding themes. BUG=139369 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149269

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	build/common.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/resources/about_version.html	View		1 chunk	+4 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

flackr

PTAL, thanks! Ted, I didn't find any other uses of the android check for enable_themes ...

8 years, 4 months ago (2012-07-31 18:43:45 UTC) #1

Ted C

lgtm I "suspect" the usage will go up as we androidify more of the webui ...

8 years, 4 months ago (2012-07-31 18:48:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/10839003/1

8 years, 4 months ago (2012-07-31 19:28:15 UTC) #4

Change committed as 149269