Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10838002: Extensions Docs Server: Sort API list (Closed)

Created:
8 years, 4 months ago by cduvall
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, clintstaley
Visibility:
Public.

Description

Extensions Docs Server: Sort API list Sort the API list by name. BUG=131095 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149015

Patch Set 1 #

Total comments: 2

Patch Set 2 : better sorting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/common/extensions/docs/server2/api_list_data_source.py View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cduvall
8 years, 4 months ago (2012-07-30 20:19:53 UTC) #1
not at google - send to devlin
https://chromiumcodereview.appspot.com/10838002/diff/1/chrome/common/extensions/docs/server2/api_list_data_source.py File chrome/common/extensions/docs/server2/api_list_data_source.py (right): https://chromiumcodereview.appspot.com/10838002/diff/1/chrome/common/extensions/docs/server2/api_list_data_source.py#newcode35 chrome/common/extensions/docs/server2/api_list_data_source.py:35: 'experimental': sorted(experimental_apis, key=lambda x: x['name']) There's an "attrgetter" thing ...
8 years, 4 months ago (2012-07-30 20:22:00 UTC) #2
cduvall
https://chromiumcodereview.appspot.com/10838002/diff/1/chrome/common/extensions/docs/server2/api_list_data_source.py File chrome/common/extensions/docs/server2/api_list_data_source.py (right): https://chromiumcodereview.appspot.com/10838002/diff/1/chrome/common/extensions/docs/server2/api_list_data_source.py#newcode35 chrome/common/extensions/docs/server2/api_list_data_source.py:35: 'experimental': sorted(experimental_apis, key=lambda x: x['name']) On 2012/07/30 20:22:00, kalman ...
8 years, 4 months ago (2012-07-30 20:26:29 UTC) #3
not at google - send to devlin
8 years, 4 months ago (2012-07-30 20:34:42 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698