Chromium Code Reviews
Help | Chromium Project | Sign in
(1044)

Issue 10837363: Introduce AutofillClient and use it to get rid of PasswordManager dependency. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by Jói
Modified:
1 year, 7 months ago
CC:
chromium-reviews_chromium.org, creis+watch_chromium.org, dyu1, dhollowa+watch_chromium.org, ajwong+watch_chromium.org, jam, darin-cc_chromium.org, browser-components-watch_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Introduce AutofillClient and use it to get rid of PasswordManager dependency.

Also, this switches use of InfoBarTabService and PrefServiceBase in
AutofillManager from calling their ::ForXyz methods, to retrieving
them via AutofillClient.

BUG=140037
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154022

Patch Set 1 #

Total comments: 14

Patch Set 2 : Address review comments, rename stuff. #

Total comments: 6

Patch Set 3 : Respond to review comments. #

Patch Set 4 : Merge to LKGR (pure merge) #

Patch Set 5 : . #

Patch Set 6 : Fix header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -29 lines) Lint Patch
M chrome/browser/autofill/DEPS View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments ? errors Download
A chrome/browser/autofill/api/autofill_manager_delegate.h View 1 1 chunk +44 lines, -0 lines 0 comments 1 errors Download
M chrome/browser/autofill/autofill_external_delegate_unittest.cc View 1 2 3 4 5 3 chunks +7 lines, -1 line 0 comments ? errors Download
M chrome/browser/autofill/autofill_manager.h View 1 2 4 chunks +9 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/autofill/autofill_manager.cc View 1 2 9 chunks +15 lines, -18 lines 0 comments ? errors Download
M chrome/browser/autofill/autofill_manager_unittest.cc View 1 2 3 4 5 3 chunks +5 lines, -1 line 0 comments ? errors Download
M chrome/browser/autofill/autofill_metrics_unittest.cc View 1 2 3 4 5 3 chunks +5 lines, -1 line 0 comments ? errors Download
M chrome/browser/plugin_infobar_delegates.cc View 1 chunk +3 lines, -5 lines 0 comments 0 errors Download
A + chrome/browser/ui/autofill/OWNERS View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
A chrome/browser/ui/autofill/tab_autofill_manager_delegate.h View 1 2 3 4 5 1 chunk +28 lines, -0 lines 0 comments 1 errors Download
A chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments 1 errors Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments ? errors Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 19
Jói
Erik, I think you will be happy to see this, as it is a step ...
1 year, 7 months ago #1
erikwright
LGTM. I would rename ChromeAutofillClient to TabContentsAutofillClient or TabAutofillClient. Reasoning is that usually the Chrome* ...
1 year, 7 months ago #2
Ilya Sherman
http://codereview.chromium.org/10837363/diff/1/chrome/browser/autofill/api/autofill_client.h File chrome/browser/autofill/api/autofill_client.h (right): http://codereview.chromium.org/10837363/diff/1/chrome/browser/autofill/api/autofill_client.h#newcode21 chrome/browser/autofill/api/autofill_client.h:21: class AutofillClient { Hmm, this seems like it is ...
1 year, 7 months ago #3
Ilya Sherman
http://codereview.chromium.org/10837363/diff/1/chrome/browser/ui/tab_contents/tab_contents.h File chrome/browser/ui/tab_contents/tab_contents.h (right): http://codereview.chromium.org/10837363/diff/1/chrome/browser/ui/tab_contents/tab_contents.h#newcode272 chrome/browser/ui/tab_contents/tab_contents.h:272: scoped_ptr<ChromeAutofillClient> autofill_client_; On 2012/08/22 03:38:03, Ilya Sherman wrote: > ...
1 year, 7 months ago #4
Jói
The AutofillClient is in fact a Delegate. I'm going to rename it AutofillManagerDelegate. It should ...
1 year, 7 months ago #5
Jói
PTAL, and see previous email on the question of naming and ownership structures. http://codereview.chromium.org/10837363/diff/1/chrome/browser/autofill/autofill_manager.h File ...
1 year, 7 months ago #6
tfarina
On Wednesday, August 22, 2012, wrote: > PTAL, and see previous email on the question ...
1 year, 7 months ago #7
erikwright
LEBTM. http://codereview.chromium.org/10837363/diff/10003/chrome/browser/tab_contents/tab_autofill_manager_delegate.h File chrome/browser/tab_contents/tab_autofill_manager_delegate.h (right): http://codereview.chromium.org/10837363/diff/10003/chrome/browser/tab_contents/tab_autofill_manager_delegate.h#newcode13 chrome/browser/tab_contents/tab_autofill_manager_delegate.h:13: // Chrome implementation of AutofillManagerClient fix classname in ...
1 year, 7 months ago #8
Ilya Sherman
LGTM (with nits). http://codereview.chromium.org/10837363/diff/1/chrome/browser/autofill/autofill_manager.h File chrome/browser/autofill/autofill_manager.h (right): http://codereview.chromium.org/10837363/diff/1/chrome/browser/autofill/autofill_manager.h#newcode178 chrome/browser/autofill/autofill_manager.h:178: autofill::AutofillClient* client_; On 2012/08/22 17:15:53, Jói ...
1 year, 7 months ago #9
Jói
+Avi: chrome/browser/tab_contents/OWNERS approval. Cheers, Jói http://codereview.chromium.org/10837363/diff/1/chrome/browser/autofill/autofill_manager.h File chrome/browser/autofill/autofill_manager.h (right): http://codereview.chromium.org/10837363/diff/1/chrome/browser/autofill/autofill_manager.h#newcode178 chrome/browser/autofill/autofill_manager.h:178: autofill::AutofillClient* client_; On 2012/08/22 ...
1 year, 7 months ago #10
Jói
FYI: I'm starting to think TabAutofillManagerDelegate belongs in chrome/browser/ui/tab_contents rather than chrome/browser/tab_contents, as my next ...
1 year, 7 months ago #11
Avi
On 2012/08/23 11:42:26, Jói wrote: > FYI: I'm starting to think TabAutofillManagerDelegate belongs in > ...
1 year, 7 months ago #12
Jói
> As opposed to chrome/browser/ui/autofill? That makes sense actually, a directory for UI stuff for ...
1 year, 7 months ago #13
erikwright
Hmm. If we take that approach, what about things that would previously have belonged in ...
1 year, 7 months ago #14
Avi
I'm not saying that _nothing_ will go there, but given that the concept of a ...
1 year, 7 months ago #15
erikwright
No objection. In the worst case we will do a bit more moving around in ...
1 year, 7 months ago #16
Jói
+ben for chrome/browser/ui/OWNERS approval Ben, just need your OK for the new directory as suggested ...
1 year, 7 months ago #17
Ben Goodger (Google)
lgtm
1 year, 7 months ago #18
I haz the power (commit-bot)
1 year, 7 months ago #19
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6