Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 10837358: Throw a more descriptive exception when blocking 'eval' via CSP. (Closed)

Created:
8 years, 4 months ago by ulan
Modified:
8 years, 3 months ago
Reviewers:
Sven Panne, Mike West
CC:
v8-dev
Visibility:
Public.

Description

Throw a more descriptive exception when blocking 'eval' via CSP. BUG=140191 R=svenpanne@chromium.org,mkwst@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12525

Patch Set 1 #

Patch Set 2 : Add SetErrorMessageForCodeGenerationFromStrings API function. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -5 lines) Patch
M include/v8.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/contexts.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M src/contexts.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/messages.js View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ulan
Please take a look.
8 years, 4 months ago (2012-08-21 12:02:53 UTC) #1
Use mkwst_at_chromium.org plz.
On 2012/08/21 12:02:53, ulan wrote: > Please take a look. Thank you, Ulan. This LGTM, ...
8 years, 4 months ago (2012-08-21 12:45:23 UTC) #2
ulan
In that case we would need to export the ErrorMessageForCodeGenerationFromStrings() function as an API function. ...
8 years, 4 months ago (2012-08-21 13:08:30 UTC) #3
Sven Panne
LGTM with one nit: error_message_for_code_gen_from_strings's type in Haskell-speak is basically 'Maybe String', this is not ...
8 years, 4 months ago (2012-08-21 14:19:57 UTC) #4
Sven Panne
8 years, 3 months ago (2012-09-17 09:56:13 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698