Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 10837350: Revert 152406 - Introduce shared_memory_support media target for PPAPI. (Closed)

Created:
8 years, 4 months ago by DaleCurtis
Modified:
8 years, 4 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Revert 152406 - Introduce shared_memory_support media target for PPAPI. Allows PPAPI to directly utilize shared memory utility code instead of duplicating it and CHECK'ing for equivalency. Required to eventually convert PPAPI to using an AudioBus and floats in PPB_Audio_Shared::Run(). http://crbug.com/114700 BUG=123203 TEST=unittests Review URL: https://chromiumcodereview.appspot.com/10826296 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152431

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -264 lines) Patch
MM content/browser/renderer_host/media/audio_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
MM content/browser/renderer_host/media/audio_sync_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
MM content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
MM media/audio/audio_output_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
MM media/audio/audio_output_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
MM media/audio/audio_output_device.cc View 2 chunks +1 line, -2 lines 0 comments Download
MM media/audio/audio_output_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
MM media/audio/audio_util.h View 1 chunk +15 lines, -0 lines 0 comments Download
MM media/audio/audio_util.cc View 3 chunks +57 lines, -2 lines 0 comments Download
D media/audio/shared_memory_util.h View 1 chunk +0 lines, -39 lines 0 comments Download
D media/audio/shared_memory_util.cc View 1 chunk +0 lines, -70 lines 0 comments Download
MM media/base/channel_layout.h View 2 chunks +4 lines, -2 lines 0 comments Download
MM media/base/channel_layout.cc View 2 chunks +2 lines, -0 lines 0 comments Download
MM media/media.gyp View 7 chunks +7 lines, -23 lines 0 comments Download
D media/media_untrusted.gyp View 1 chunk +0 lines, -44 lines 0 comments Download
D media/shared_memory_support.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
MM ppapi/native_client/native_client.gyp View 18 chunks +0 lines, -27 lines 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_audio_rpc_server.cc View 2 chunks +1 line, -2 lines 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/plugin_globals.h View 1 chunk +8 lines, -0 lines 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_audio.cc View 5 chunks +18 lines, -7 lines 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy_untrusted.gyp View 2 chunks +1 line, -3 lines 0 comments Download
MM ppapi/native_client/src/trusted/plugin/plugin.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
MM ppapi/ppapi_host.gypi View 1 chunk +0 lines, -1 line 0 comments Download
MM ppapi/ppapi_internal.gyp View 1 chunk +0 lines, -1 line 0 comments Download
MM ppapi/ppapi_shared_untrusted.gyp View 1 chunk +0 lines, -1 line 0 comments Download
MM ppapi/ppapi_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
MM ppapi/shared_impl/ppb_audio_shared.h View 1 chunk +3 lines, -0 lines 0 comments Download
MM ppapi/shared_impl/ppb_audio_shared.cc View 4 chunks +29 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
DaleCurtis
8 years, 4 months ago (2012-08-20 23:50:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698